From 882c1524f7fc65deb534b7d5bd9c39141bc5de24 Mon Sep 17 00:00:00 2001 From: Neil Lalonde Date: Tue, 30 Jul 2013 16:48:19 -0400 Subject: [PATCH] Strip trailing and leading spaces from category names --- app/models/category.rb | 1 + spec/models/category_spec.rb | 13 ++++++++++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/app/models/category.rb b/app/models/category.rb index b055770d5c6..853d94ddfde 100644 --- a/app/models/category.rb +++ b/app/models/category.rb @@ -121,6 +121,7 @@ class Category < ActiveRecord::Base def ensure_slug if name.present? + self.name.strip! self.slug = Slug.for(name) return if self.slug.blank? diff --git a/spec/models/category_spec.rb b/spec/models/category_spec.rb index afb16f5f6e7..df4353556f7 100644 --- a/spec/models/category_spec.rb +++ b/spec/models/category_spec.rb @@ -122,6 +122,18 @@ describe Category do end end + it "strips leading blanks" do + Fabricate(:category, name: " music").name.should == "music" + end + + it "strips trailing blanks" do + Fabricate(:category, name: "bugs ").name.should == "bugs" + end + + it "strips leading and trailing blanks" do + Fabricate(:category, name: " blanks ").name.should == "blanks" + end + describe "short name" do let!(:category) { Fabricate(:category, name: 'xx') } @@ -218,7 +230,6 @@ describe Category do @topic.category.should == @category @category.topic.should == @topic end - end end