github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 14:38:17 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: when using arrow to bottom fetch from newest (#22860)

Browse Source 
We were attempting to fetch from last read but this is actually complicated to get right when you have a lot unread, as we might still have more to load after this but the last unread id is still the same and would make the user end up in a loop.
This commit is contained in:
Joffrey JAFFEUX 2023-07-28 19:31:28 +02:00 committed by GitHub
parent 98e3bbd6bf
commit 891aabde19
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
plugins/chat/assets/javascripts/discourse/components/chat-channel.js
View File

@ -427,9 +427,8 @@ export default class ChatChannel extends Component {
@action @action
scrollToLatestMessage() { scrollToLatestMessage() {
if (this.messagesLoader.canLoadMoreFuture) { if (this.messagesLoader.canLoadMoreFuture) {
this.fetchMessages({ fetch_from_last_read: true }); this.fetchMessages();
} else if (this.messagesManager.messages.length > 0) { } else if (this.messagesManager.messages.length > 0) {
this._ignoreNextScroll = true;
this.scrollToBottom(this.scrollable); this.scrollToBottom(this.scrollable);
} }
} }