github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-20 22:01:40 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: uses simpler pattern for custom href on extra nav items (#8015)

Browse Source 
THe main advantage of this solution is that it will be called on each rerendered whereas the other is not once href has been set.

Example API:
```
      api.addNavigationBarItem({
        name: "foo",
        displayName: "Foo",
        customHref: function(category, args) {
          const router = api.container.lookup("service:router");
          const queryParams = { bar: "1" };
          return router.urlFor(router.currentRouteName, category, {
            queryParams
          });
        }
      });
```
This commit is contained in:
Joffrey JAFFEUX 2019-08-19 08:27:16 +02:00 committed by Sam
parent 10b36c6446
commit 897cdfb596
1 changed files with 7 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
app/assets/javascripts/discourse/models/nav-item.js.es6
View File

@ -101,18 +101,8 @@ const NavItem = Discourse.Model.extend({
}); });
const ExtraNavItem = NavItem.extend({ const ExtraNavItem = NavItem.extend({
href: Ember.computed({ @computed("href")
set(key, value) { href: href => href,
let customHref;
NavItem.customNavItemHrefs.forEach(function(cb) {
customHref = cb.call(this, this);
if (customHref) {
return false;
}
}, this);
return customHref || value;
}
}),
customFilter: null customFilter: null
}); });
@ -189,6 +179,11 @@ NavItem.reopenClass({
return item.customFilter.call(this, category, args); return item.customFilter.call(this, category, args);
}); });
extraItems.forEach(item => {
if (!item.customHref) return;
item.set("href", item.customHref.call(this, category, args));
});
return items.concat(extraItems); return items.concat(extraItems);
} }
}); });