github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 09:11:38 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: add anonymousOnly opt to registerTopicFooterButton (#25293)

Browse Source 
Adds support to `anonymousOnly` as an option when using `registerTopicFooterButton`, rendering the buttons accordingly.
This commit is contained in:
Renato Atilio 2024-01-17 21:10:42 -03:00 committed by GitHub
parent e3f0c8682a
commit 89eae4c6e3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
6 changed files with 128 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
app/assets/javascripts/discourse/app/components/anonymous-topic-footer-buttons.hbs Normal file
View File

@ -0,0 +1,24 @@
<div class="topic-footer-main-buttons">
{{#each this.buttons as |button|}}
<DButton
@action={{button.action}}
@icon={{button.icon}}
@translatedLabel={{button.label}}
@translatedTitle={{button.title}}
@translatedAriaLabel={{button.ariaLabel}}
@disabled={{button.disabled}}
id={{concat "topic-footer-button-" button.id}}
class={{concatClass
"btn-default"
"topic-footer-button"
button.classNames
}}
/>
{{/each}}
<DButton
@icon="reply"
@action={{route-action "showLogin"}}
@label="topic.reply.title"
class="btn-primary"
/>
</div>

21
app/assets/javascripts/discourse/app/components/anonymous-topic-footer-buttons.js Normal file
View File

@ -0,0 +1,21 @@
import Component from "@ember/component";
import { computed } from "@ember/object";
import { getTopicFooterButtons } from "discourse/lib/register-topic-footer-button";
export default Component.extend({
elementId: "topic-footer-buttons",
attributeBindings: ["role"],
role: "region",
allButtons: getTopicFooterButtons(),
@computed("allButtons.[]")
get buttons() {
return this.allButtons
.filterBy("anonymousOnly", true)
.sortBy("priority")
.reverse();
},
});

1
app/assets/javascripts/discourse/app/components/topic-footer-buttons.js
View File

@ -27,6 +27,7 @@ export default Component.extend({
function () {
return this.inlineButtons
.filterBy("dropdown", false)
.filterBy("anonymousOnly", false)
.concat(this.inlineDropdowns)
.sortBy("priority")
.reverse();

8
app/assets/javascripts/discourse/app/lib/register-topic-footer-button.js
View File

@ -51,6 +51,9 @@ export function registerTopicFooterButton(button) {
// display order, higher comes first
priority: 0,
// is this button displayed for anonymous users ?
anonymousOnly: false,
};
const normalizedButton = Object.assign(defaultButton, button);
@ -126,6 +129,11 @@ export function getTopicFooterButtons() {
discourseComputedButton.dropdown = _compute(button, "dropdown");
discourseComputedButton.priority = _compute(button, "priority");
discourseComputedButton.anonymousOnly = _compute(
button,
"anonymousOnly"
);
if (_isFunction(button.action)) {
discourseComputedButton.action = () => button.action.apply(this);
} else {

7
app/assets/javascripts/discourse/app/templates/topic.hbs
View File

@ -542,12 +542,7 @@
/>
{{else}}
<div id="topic-footer-buttons">
<DButton
@icon="reply"
@action={{route-action "showLogin"}}
@label="topic.reply.title"
class="btn-primary"
/>
<AnonymousTopicFooterButtons @topic={{this.model}} />
</div>
{{/if}}
{{/if}}

91
app/assets/javascripts/discourse/tests/acceptance/topic-footer-button-api-test.js
View File

@ -1,27 +1,82 @@
import { click, visit } from "@ember/test-helpers";
import { test } from "qunit";
import { withPluginApi } from "discourse/lib/plugin-api";
import { acceptance } from "discourse/tests/helpers/qunit-helpers";
import { acceptance, exists } from "discourse/tests/helpers/qunit-helpers";
acceptance("Topic - Plugin API - registerTopicFooterButton", function (needs) {
needs.user();
acceptance(
"Topic - Plugin API - registerTopicFooterButton - logged in user",
function (needs) {
needs.user();
test("adds topic footer button through API", async function (assert) {
const done = assert.async();
withPluginApi("0.13.1", (api) => {
api.registerTopicFooterButton({
id: "my-button",
icon: "cog",
action() {
assert.step("action called");
done();
},
test("adds topic footer button through API", async function (assert) {
const done = assert.async();
withPluginApi("0.13.1", (api) => {
api.registerTopicFooterButton({
id: "my-button",
icon: "cog",
action() {
assert.step("action called");
done();
},
});
});
await visit("/t/internationalization-localization/280");
await click("#topic-footer-button-my-button");
assert.verifySteps(["action called"]);
});
await visit("/t/internationalization-localization/280");
await click("#topic-footer-button-my-button");
test("doesn't show footer button if anonymousOnly is true", async function (assert) {
withPluginApi("0.13.1", (api) => {
api.registerTopicFooterButton({
id: "my-button",
icon: "cog",
action() {},
anonymousOnly: true,
});
});
assert.verifySteps(["action called"]);
});
});
await visit("/t/internationalization-localization/280");
assert.ok(!exists("#topic-footer-button-my-button"));
});
}
);
acceptance(
"Topic - Plugin API - registerTopicFooterButton - anonymous",
function () {
test("adds topic footer button through API", async function (assert) {
const done = assert.async();
withPluginApi("0.13.1", (api) => {
api.registerTopicFooterButton({
id: "my-button",
icon: "cog",
action() {
assert.step("action called");
done();
},
anonymousOnly: true,
});
});
await visit("/t/internationalization-localization/280");
await click("#topic-footer-button-my-button");
assert.verifySteps(["action called"]);
});
test("doesn't show footer button if anonymousOnly is false/unset", async function (assert) {
withPluginApi("0.13.1", (api) => {
api.registerTopicFooterButton({
id: "my-button",
icon: "cog",
action() {},
});
});
await visit("/t/internationalization-localization/280");
assert.ok(!exists("#topic-footer-button-my-button"));
});
}
);