From 8b37dadec77033c02d4f1b442481609b00a33825 Mon Sep 17 00:00:00 2001 From: Kane York Date: Tue, 1 Sep 2015 16:52:29 -0700 Subject: [PATCH] remove TODO --- .../javascripts/discourse/initializers/signup-cta.js.es6 | 4 ++-- app/assets/javascripts/discourse/lib/screen-track.js.es6 | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/app/assets/javascripts/discourse/initializers/signup-cta.js.es6 b/app/assets/javascripts/discourse/initializers/signup-cta.js.es6 index 8b6011f3557..cc25f64cb8d 100644 --- a/app/assets/javascripts/discourse/initializers/signup-cta.js.es6 +++ b/app/assets/javascripts/discourse/initializers/signup-cta.js.es6 @@ -17,6 +17,8 @@ export default { keyValueStore = container.lookup('key-value-store:main'), user = container.lookup('current-user:main'); + screenTrack.set('keyValueStore', keyValueStore); + // Preconditions if (user) return; // must not be logged in @@ -27,8 +29,6 @@ export default { if (siteSettings.login_required) return; if (!siteSettings.enable_signup_cta) return; - screenTrack.set('keyValueStore', keyValueStore); - function checkSignupCtaRequirements() { if (session.get('showSignupCta')) { return; // already shown diff --git a/app/assets/javascripts/discourse/lib/screen-track.js.es6 b/app/assets/javascripts/discourse/lib/screen-track.js.es6 index 345796ccc24..26451f433cd 100644 --- a/app/assets/javascripts/discourse/lib/screen-track.js.es6 +++ b/app/assets/javascripts/discourse/lib/screen-track.js.es6 @@ -10,8 +10,6 @@ const ScreenTrack = Ember.Object.extend({ init() { this.reset(); - // TODO fix this - this.set('keyValueStore', Discourse.__container__.lookup('key-value-store:main')); }, start(topicId, topicController) {