mirror of
https://github.com/discourse/discourse.git
synced 2025-02-24 06:27:24 +08:00
DEV: Fix a warning in a chat spec (#30904)
``` Checking for expected text of nil is confusing and/or pointless since it will always match. Please specify a string or regexp instead. plugins/chat/spec/system/chat_message_interaction_spec.rb:51 ```
This commit is contained in:
parent
a3359ac7ad
commit
8e31991613
@ -48,7 +48,10 @@ RSpec.describe "Interacting with a message", type: :system do
|
||||
DiscourseEvent.on(:chat_message_interaction, &blk)
|
||||
find(".block__button").click
|
||||
|
||||
try_until_success { expect(chat_channel_page.messages).to have_text(action_id) }
|
||||
try_until_success do
|
||||
expect(action_id).to_not be_nil
|
||||
expect(chat_channel_page.messages).to have_text(action_id)
|
||||
end
|
||||
ensure
|
||||
DiscourseEvent.off(:chat_message_interaction, &blk)
|
||||
end
|
||||
|
Loading…
x
Reference in New Issue
Block a user