github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 07:30:16 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Prefer update! over update when return value is not checked.

Browse Source
This commit is contained in:
Guo Xiang Tan 2020-09-24 09:56:09 +08:00
parent d745568633
commit 911d47934a
No known key found for this signature in database
GPG Key ID: FBD110179AAC1F20
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
spec/requests/topics_controller_spec.rb
View File

@ -1280,18 +1280,19 @@ RSpec.describe TopicsController do
describe "when first post is locked" do
it "blocks non-staff from editing even if 'trusted_users_can_edit_others' is true" do
SiteSetting.trusted_users_can_edit_others = true
user.update(trust_level: 3)
topic.first_post.update(locked_by_id: admin.id)
user.update!(trust_level: 3)
topic.first_post.update!(locked_by_id: admin.id)
put "/t/#{topic.slug}/#{topic.id}.json", params: {
title: topic.title + " hello"
}
expect(response.status).to eq(403)
end
it "allows staff to edit" do
sign_in(Fabricate(:admin))
topic.first_post.update(locked_by_id: admin.id)
topic.first_post.update!(locked_by_id: admin.id)
put "/t/#{topic.slug}/#{topic.id}.json", params: {
title: topic.title + " hello"