From 93c32b9e074ea4ef4e745886e65621507c7f3d53 Mon Sep 17 00:00:00 2001 From: Martin Brennan Date: Thu, 7 Sep 2023 12:38:38 +1000 Subject: [PATCH] DEV: Temporarily skip minio system specs (#23450) Doing this because the same issue exists as did for chromedriver fixed by TGX in X for minio. Need time to add support for parallel tests in the minio_runner gem so this doesn't happen: ``` Failure/Error: File.open(dest, "wb", s.stat.mode) do |f| IO.copy_stream(s, f) f.chmod(f.lstat.mode) end Errno::ETXTBSY: Text file busy @ rb_sysopen - /github/home/.minio_runner/minio ./lib/freedom_patches/copy_file.rb:10:in `copy_file' ./vendor/bundle/ruby/3.2.0/gems/minio_runner-0.1.1/lib/minio_runner/binary_manager.rb:49:in `block in download_binary' ./vendor/bundle/ruby/3.2.0/gems/minio_runner-0.1.1/lib/minio_runner/network.rb:72:in `download' ./vendor/bundle/ruby/3.2.0/gems/minio_runner-0.1.1/lib/minio_runner/binary_manager.rb:48:in `download_binary' ./vendor/bundle/ruby/3.2.0/gems/minio_runner-0.1.1/lib/minio_runner/binary_manager.rb:29:in `install' ./vendor/bundle/ruby/3.2.0/gems/minio_runner-0.1.1/lib/minio_runner/binary_manager.rb:9:in `install' ./vendor/bundle/ruby/3.2.0/gems/minio_runner-0.1.1/lib/minio_runner.rb:62:in `install_binaries' ./vendor/bundle/ruby/3.2.0/gems/minio_runner-0.1.1/lib/minio_runner.rb:50:in `start' ./spec/support/system_helpers.rb:157:in `setup_s3_system_test' ``` --- spec/support/system_helpers.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/spec/support/system_helpers.rb b/spec/support/system_helpers.rb index 4bd88635931..294276f49db 100644 --- a/spec/support/system_helpers.rb +++ b/spec/support/system_helpers.rb @@ -158,6 +158,8 @@ module SystemHelpers end def skip_unless_s3_system_specs_enabled! + skip("(martin) temporarily skipping minio tests because of parralel binary issues") + if !ENV["CI"] && !ENV["RUN_S3_SYSTEM_SPECS"] skip( "S3 system specs are disabled in this environment, set CI=1 or RUN_S3_SYSTEM_SPECS=1 to enable them.",