github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 10:57:04 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Add rawTitle property support to modal-tab (#10221)

Browse Source 
```js
const panels = [
  { id: "test1", rawTitle: "Test 1" },
  { id: "test2", rawTitle: "Test 2" }
];

showModal("a-modal", { panels }));
```
This commit is contained in:
Jarek Radosz 2020-07-13 01:26:45 +02:00 committed by GitHub
parent 544a9865c6
commit 942cc9b57a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 28 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
app/assets/javascripts/discourse/app/components/modal-tab.js
View File

@ -1,6 +1,8 @@
import { equal, alias } from "@ember/object/computed";
import I18n from "I18n";
import Component from "@ember/component";
import { equal } from "@ember/object/computed";
import { propertyEqual } from "discourse/lib/computed";
import discourseComputed from "discourse-common/utils/decorators";
export default Component.extend({
tagName: "li",
@ -10,9 +12,13 @@ export default Component.extend({
panelsLength: null,
classNameBindings: ["isActive", "singleTab", "panel.id"],
singleTab: equal("panelsLength", 1),
title: alias("panel.title"),
isActive: propertyEqual("panel.id", "selectedPanel.id"),
@discourseComputed("panel.title", "panel.rawTitle")
title(title, rawTitle) {
return title ? I18n.t(title) : rawTitle;
},
click() {
this.onSelectPanel(this.panel);
}

2
app/assets/javascripts/discourse/app/templates/components/modal-tab.hbs
View File

@ -1 +1 @@
{{i18n title}}
{{title}}

19
test/javascripts/acceptance/modal-test.js
View File

@ -54,6 +54,25 @@ QUnit.skip("modal", async function(assert) {
);
});
QUnit.test("rawTitle in modal panels", async function(assert) {
Ember.TEMPLATES["modal/test-raw-title-panels"] = Ember.HTMLBars.compile("");
const panels = [
{ id: "test1", rawTitle: "Test 1" },
{ id: "test2", rawTitle: "Test 2" }
];
await visit("/");
run(() => showModal("test-raw-title-panels", { panels }));
assert.equal(
find(".d-modal .modal-tab:first-child")
.text()
.trim(),
"Test 1",
"it should display the raw title"
);
});
acceptance("Modal Keyboard Events", { loggedIn: true });
QUnit.test("modal-keyboard-events", async function(assert) {