github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 23:54:16 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Remove non-legit test, we should always change attributes even if external is unchanged

Browse Source 
Overriding should be all or nothing
This commit is contained in:
Sam 2015-03-27 09:57:43 +11:00
parent 4566a1e30a
commit 94fceaf517
1 changed files with 1 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
spec/controllers/session_controller_spec.rb
View File

@ -89,7 +89,7 @@ describe SessionController do
it 'respects IP restrictions on login' do
sso = sso_for_ip_specs
user = DiscourseSingleSignOn.parse(sso.payload).lookup_or_create_user(request.remote_ip)
_user = DiscourseSingleSignOn.parse(sso.payload).lookup_or_create_user(request.remote_ip)
sso = sso_for_ip_specs
screened_ip = Fabricate(:screened_ip_address)
@ -304,18 +304,6 @@ describe SessionController do
expect(logged_on_user.email).to eq(@user.email)
end
it 'does not change attributes for unchanged external attributes' do
@user.single_sign_on_record.external_username = @sso.username
@user.single_sign_on_record.external_email = @sso.email
@user.single_sign_on_record.external_name = @sso.name
@user.single_sign_on_record.save
get :sso_login, Rack::Utils.parse_query(@sso.payload)
logged_on_user = Discourse.current_user_provider.new(request.env).current_user
expect(logged_on_user.username).to eq(@user.username)
expect(logged_on_user.email).to eq(@user.email)
expect(logged_on_user.name).to eq(@user.name)
end
end
end