github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 14:49:07 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Revert "FIX: Regularly reset unknown extension of uploads"

Browse Source 
This reverts commit cc7b24b88b as it shouldn't be needed anymore for new uploads.
This commit is contained in:
Gerhard Schlager 2020-08-03 13:37:32 +02:00
parent fe83baa9b3
commit 957e851ffe
3 changed files with 0 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/jobs/scheduled/weekly.rb
View File

@ -12,7 +12,6 @@ module Jobs
MiniScheduler::Stat.purge_old MiniScheduler::Stat.purge_old
Draft.cleanup! Draft.cleanup!
UserAuthToken.cleanup! UserAuthToken.cleanup!
Upload.reset_unknown_extensions!
Email::Cleaner.delete_rejected! Email::Cleaner.delete_rejected!
Notification.purge_old! Notification.purge_old!
end end

4
app/models/upload.rb
View File

@ -401,10 +401,6 @@ class Upload < ActiveRecord::Base
problems problems
end end
def self.reset_unknown_extensions!
Upload.where(extension: "unknown").update_all(extension: nil)
end
private private
def short_url_basename def short_url_basename

12
spec/models/upload_spec.rb
View File

@ -399,18 +399,6 @@ describe Upload do
end end
end end
describe '.reset_unknown_extensions!' do
it 'should reset the extension of uploads when it is "unknown"' do
upload1 = Fabricate(:upload, extension: "unknown")
upload2 = Fabricate(:upload, extension: "png")
Upload.reset_unknown_extensions!
expect(upload1.reload.extension).to eq(nil)
expect(upload2.reload.extension).to eq("png")
end
end
def enable_secure_media def enable_secure_media
SiteSetting.enable_s3_uploads = true SiteSetting.enable_s3_uploads = true
SiteSetting.s3_upload_bucket = "s3-upload-bucket" SiteSetting.s3_upload_bucket = "s3-upload-bucket"