github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 03:40:00 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Safely return from missing post on check_dont_feed_the_trolls (#21238)

Browse Source
This commit is contained in:
Isaac Janzen 2023-04-25 10:08:00 -05:00 committed by GitHub
parent 4e0c07c56d
commit 96700d55a4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/composer_messages_finder.rb
View File

@ -233,7 +233,7 @@ class ComposerMessagesFinder
if @details[:post_id] if @details[:post_id]
Post.find_by(id: @details[:post_id]) Post.find_by(id: @details[:post_id])
else else
@topic.first_post @topic&.first_post
end end
return if post.blank? return if post.blank?

5
spec/lib/composer_messages_finder_spec.rb
View File

@ -395,6 +395,11 @@ RSpec.describe ComposerMessagesFinder do
) )
expect(finder.check_dont_feed_the_trolls).to be_present expect(finder.check_dont_feed_the_trolls).to be_present
end end
it "safely returns from not finding a post" do
finder = ComposerMessagesFinder.new(user, composer_action: "reply", topic_id: nil)
expect(finder.check_dont_feed_the_trolls).to be_blank
end
end end
describe ".check_get_a_room" do describe ".check_get_a_room" do