github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-22 19:59:40 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

REFACTOR: metadata controller specs to requests (#5935)

Browse Source
This commit is contained in:
OsamaSayegh 2018-06-07 08:08:28 +03:00 committed by Guo Xiang Tan
parent 1957cb541b
commit 9975f9751e
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
spec/controllers/metadata_controller_spec.rb → spec/requests/metadata_controller_spec.rb
View File

@ -3,12 +3,12 @@ require 'rails_helper'
RSpec.describe MetadataController do RSpec.describe MetadataController do
describe 'manifest.json' do describe 'manifest.json' do
it 'returns the right output' do it 'returns the right output' do
title = 'MyApp' title = 'MyApp'
SiteSetting.title = title SiteSetting.title = title
SiteSetting.large_icon_url = "http://big.square/png" SiteSetting.large_icon_url = "http://big.square/png"
get :manifest get "/manifest.json"
expect(response.status).to eq(200)
expect(response.content_type).to eq('application/json') expect(response.content_type).to eq('application/json')
manifest = JSON.parse(response.body) manifest = JSON.parse(response.body)
@ -18,14 +18,16 @@ RSpec.describe MetadataController do
it 'can guess mime types' do it 'can guess mime types' do
SiteSetting.large_icon_url = "http://big.square/ico.jpg" SiteSetting.large_icon_url = "http://big.square/ico.jpg"
get :manifest get "/manifest.json"
expect(response.status).to eq(200)
manifest = JSON.parse(response.body) manifest = JSON.parse(response.body)
expect(manifest["icons"].first["type"]).to eq("image/jpeg") expect(manifest["icons"].first["type"]).to eq("image/jpeg")
end end
it 'defaults to png' do it 'defaults to png' do
SiteSetting.large_icon_url = "http://big.square/noidea.bogus" SiteSetting.large_icon_url = "http://big.square/noidea.bogus"
get :manifest get "/manifest.json"
expect(response.status).to eq(200)
manifest = JSON.parse(response.body) manifest = JSON.parse(response.body)
expect(manifest["icons"].first["type"]).to eq("image/png") expect(manifest["icons"].first["type"]).to eq("image/png")
end end
@ -37,7 +39,8 @@ RSpec.describe MetadataController do
favicon_path = '/uploads/something/23432.png' favicon_path = '/uploads/something/23432.png'
SiteSetting.title = title SiteSetting.title = title
SiteSetting.favicon_url = favicon_path SiteSetting.favicon_url = favicon_path
get :opensearch, format: :xml get "/opensearch.xml"
expect(response.status).to eq(200)
expect(response.body).to include(title) expect(response.body).to include(title)
expect(response.body).to include("/search?q={searchTerms}") expect(response.body).to include("/search?q={searchTerms}")
expect(response.body).to include('image/png') expect(response.body).to include('image/png')