github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-25 18:53:44 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

DEV: Remove deprecated arguments to Plugin::Instande#add_api_parameter_route (#22736)

Browse Source 
We deprecated the keywords method, route, and format (replaced with methods, actions, and formats respectively) as parameters to Plugin::Instance#add_api_parameter_route, marked for removal in 2.7. This PR deletes them.
This commit is contained in:
Ted Johansson 2023-07-21 12:22:33 +08:00 committed by GitHub
parent a9a568d112
commit a0ad7d0a04
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
lib/plugin/instance.rb
View File

@ -971,36 +971,7 @@ class Plugin::Instance
#
# See Auth::DefaultCurrentUserProvider::PARAMETER_API_PATTERNS for more examples
# and Auth::DefaultCurrentUserProvider#api_parameter_allowed? for implementation
def add_api_parameter_route(
method: nil,
methods: nil,
route: nil,
actions: nil,
format: nil,
formats: nil
)
if Array(format).include?("*")
Discourse.deprecate(
"* is no longer a valid api_parameter_route format matcher. Use `nil` instead",
drop_from: "2.7",
raise_error: true,
)
# Old API used * as wildcard. New api uses `nil`
format = nil
end
# Backwards compatibility with old parameter names:
if method || route || format
Discourse.deprecate(
"method, route and format parameters for api_parameter_routes are deprecated. Use methods, actions and formats instead.",
drop_from: "2.7",
raise_error: true,
)
methods ||= method
actions ||= route
formats ||= format
end
def add_api_parameter_route(methods: nil, actions: nil, formats: nil)
DiscoursePluginRegistry.register_api_parameter_route(
RouteMatcher.new(methods: methods, actions: actions, formats: formats),
self,