github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 03:09:00 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: Improve menu panel height fallback for older browsers (#20673)

Browse Source 
Tested with Chrome <100, Firefox <100 and Samsung Internet 20, using
percentage-based height here works better for these browsers.

This was especially a problem for the Samsung Internet browser, because
it previously was hiding the "Dismiss" button on the user profile menu.
This commit is contained in:
Penar Musaraj 2023-03-14 10:41:38 -04:00 committed by GitHub
parent 4cf065c480
commit a208ed0925
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/assets/stylesheets/common/base/menu-panel.scss
View File

@ -711,9 +711,10 @@ body.footer-nav-ipad {
top: var(--header-top);
box-sizing: border-box;
/* Use dvh where supported, with fallback to vh */
--100dvh: 100vh;
--100dvh: 100dvh;
--100dvh: 100%;
@supports (height: 100dvh) {
--100dvh: 100dvh;
}
--base-height: calc(
var(--100dvh) - var(--header-top) - env(safe-area-inset-bottom, 0px)