github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 09:12:45 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Use helperFn in d-presence (#29461)

Browse Source
This commit is contained in:
Jarek Radosz 2024-10-29 11:21:33 +01:00 committed by GitHub
parent 7af728048c
commit a236e368e4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 66 additions and 67 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
plugins/discourse-presence/assets/javascripts/discourse/components/composer-presence-display.gjs
View File

@ -1,10 +1,10 @@
import Component from "@glimmer/component"; import Component from "@glimmer/component";
import { cached, tracked } from "@glimmer/tracking"; import { cached, tracked } from "@glimmer/tracking";
import { service } from "@ember/service"; import { service } from "@ember/service";
import { modifier } from "ember-modifier";
import { gt } from "truth-helpers"; import { gt } from "truth-helpers";
import UserLink from "discourse/components/user-link"; import UserLink from "discourse/components/user-link";
import avatar from "discourse/helpers/avatar"; import avatar from "discourse/helpers/avatar";
import helperFn from "discourse/helpers/helper-fn";
import i18n from "discourse-common/helpers/i18n"; import i18n from "discourse-common/helpers/i18n";
export default class ComposerPresenceDisplay extends Component { export default class ComposerPresenceDisplay extends Component {
@ -17,7 +17,7 @@ export default class ComposerPresenceDisplay extends Component {
@tracked whisperChannel; @tracked whisperChannel;
@tracked editChannel; @tracked editChannel;
setupReplyChannel = modifier(() => { setupReplyChannel = helperFn((_, on) => {
const topic = this.args.model.topic; const topic = this.args.model.topic;
if (!topic || !this.isReply) { if (!topic || !this.isReply) {
return; return;
@ -29,10 +29,10 @@ export default class ComposerPresenceDisplay extends Component {
replyChannel.subscribe(); replyChannel.subscribe();
this.replyChannel = replyChannel; this.replyChannel = replyChannel;
return () => replyChannel.unsubscribe(); on.cleanup(() => replyChannel.unsubscribe());
}); });
setupWhisperChannel = modifier(() => { setupWhisperChannel = helperFn((_, on) => {
if ( if (
!this.args.model.topic || !this.args.model.topic ||
!this.isReply || !this.isReply ||
@ -48,10 +48,10 @@ export default class ComposerPresenceDisplay extends Component {
whisperChannel.subscribe(); whisperChannel.subscribe();
this.whisperChannel = whisperChannel; this.whisperChannel = whisperChannel;
return () => whisperChannel.unsubscribe(); on.cleanup(() => whisperChannel.unsubscribe());
}); });
setupEditChannel = modifier(() => { setupEditChannel = helperFn((_, on) => {
if (!this.args.model.post || !this.isEdit) { if (!this.args.model.post || !this.isEdit) {
return; return;
} }
@ -62,10 +62,10 @@ export default class ComposerPresenceDisplay extends Component {
editChannel.subscribe(); editChannel.subscribe();
this.editChannel = editChannel; this.editChannel = editChannel;
return () => editChannel.unsubscribe(); on.cleanup(() => editChannel.unsubscribe());
}); });
notifyState = modifier(() => { notifyState = helperFn((_, on) => {
const { topic, post, reply } = this.args.model; const { topic, post, reply } = this.args.model;
const raw = this.isEdit ? post?.raw || "" : ""; const raw = this.isEdit ? post?.raw || "" : "";
const entity = this.isEdit ? post : topic; const entity = this.isEdit ? post : topic;
@ -74,7 +74,7 @@ export default class ComposerPresenceDisplay extends Component {
this.composerPresenceManager.notifyState(this.state, entity?.id); this.composerPresenceManager.notifyState(this.state, entity?.id);
} }
return () => this.composerPresenceManager.leave(); on.cleanup(() => this.composerPresenceManager.leave());
}); });
get isReply() { get isReply() {
@ -112,12 +112,11 @@ export default class ComposerPresenceDisplay extends Component {
} }
<template> <template>
<div
{{this.setupReplyChannel}} {{this.setupReplyChannel}}
{{this.setupWhisperChannel}} {{this.setupWhisperChannel}}
{{this.setupEditChannel}} {{this.setupEditChannel}}
{{this.notifyState}} {{this.notifyState}}
>
{{#if (gt this.users.length 0)}} {{#if (gt this.users.length 0)}}
<div class="presence-users"> <div class="presence-users">
<div class="presence-avatars"> <div class="presence-avatars">
@ -144,6 +143,5 @@ export default class ComposerPresenceDisplay extends Component {
</span> </span>
</div> </div>
{{/if}} {{/if}}
</div>
</template> </template>
} }

15
plugins/discourse-presence/assets/javascripts/discourse/components/topic-presence-display.gjs
View File

@ -1,10 +1,10 @@
import Component from "@glimmer/component"; import Component from "@glimmer/component";
import { cached, tracked } from "@glimmer/tracking"; import { cached, tracked } from "@glimmer/tracking";
import { service } from "@ember/service"; import { service } from "@ember/service";
import { modifier } from "ember-modifier";
import { gt } from "truth-helpers"; import { gt } from "truth-helpers";
import UserLink from "discourse/components/user-link"; import UserLink from "discourse/components/user-link";
import avatar from "discourse/helpers/avatar"; import avatar from "discourse/helpers/avatar";
import helperFn from "discourse/helpers/helper-fn";
import i18n from "discourse-common/helpers/i18n"; import i18n from "discourse-common/helpers/i18n";
export default class TopicPresenceDisplay extends Component { export default class TopicPresenceDisplay extends Component {
@ -14,17 +14,17 @@ export default class TopicPresenceDisplay extends Component {
@tracked replyChannel; @tracked replyChannel;
@tracked whisperChannel; @tracked whisperChannel;
setupReplyChannel = modifier(() => { setupReplyChannel = helperFn((_, on) => {
const replyChannel = this.presence.getChannel( const replyChannel = this.presence.getChannel(
`/discourse-presence/reply/${this.args.topic.id}` `/discourse-presence/reply/${this.args.topic.id}`
); );
replyChannel.subscribe(); replyChannel.subscribe();
this.replyChannel = replyChannel; this.replyChannel = replyChannel;
return () => replyChannel.unsubscribe(); on.cleanup(() => replyChannel.unsubscribe());
}); });
setupWhisperChannels = modifier(() => { setupWhisperChannels = helperFn((_, on) => {
if (!this.currentUser.staff) { if (!this.currentUser.staff) {
return; return;
} }
@ -35,7 +35,7 @@ export default class TopicPresenceDisplay extends Component {
whisperChannel.subscribe(); whisperChannel.subscribe();
this.whisperChannel = whisperChannel; this.whisperChannel = whisperChannel;
return () => whisperChannel.unsubscribe(); on.cleanup(() => whisperChannel.unsubscribe());
}); });
@cached @cached
@ -49,7 +49,9 @@ export default class TopicPresenceDisplay extends Component {
} }
<template> <template>
<div {{this.setupReplyChannel}} {{this.setupWhisperChannels}}> {{this.setupReplyChannel}}
{{this.setupWhisperChannels}}
{{#if (gt this.users.length 0)}} {{#if (gt this.users.length 0)}}
<div class="presence-users"> <div class="presence-users">
<div class="presence-avatars"> <div class="presence-avatars">
@ -72,6 +74,5 @@ export default class TopicPresenceDisplay extends Component {
</span> </span>
</div> </div>
{{/if}} {{/if}}
</div>
</template> </template>
} }