From a38830c009ebb780f1fb395d60dfe8f43f69552c Mon Sep 17 00:00:00 2001 From: David Taylor Date: Mon, 7 Aug 2023 17:03:13 +0100 Subject: [PATCH] DEV: Avoid site-header error when rendering fails (#22993) When Ember rendering fails for some reason, `this.header` will be undefined. This causes site-header to raise an error, which often gets printed to the console more obviously than the actual root cause. This commit makes site-header fail more gracefully in this situation, to avoid it being a red-herring during development/debugging. --- app/assets/javascripts/discourse/app/components/site-header.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/javascripts/discourse/app/components/site-header.js b/app/assets/javascripts/discourse/app/components/site-header.js index 01dd38728a0..8490dec6394 100644 --- a/app/assets/javascripts/discourse/app/components/site-header.js +++ b/app/assets/javascripts/discourse/app/components/site-header.js @@ -486,7 +486,7 @@ export default SiteHeaderComponent.extend({ this._resizeObserver = new ResizeObserver((entries) => { for (let entry of entries) { if (entry.contentRect) { - const headerTop = this.header.offsetTop; + const headerTop = this.header?.offsetTop; document.documentElement.style.setProperty( "--header-top", `${headerTop}px`