github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-29 06:53:39 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Set priorities on user tips (#29176)

Browse Source 
Currently the topic timeline tip appears before the suggested topics one only due to a small implementation detail in the latter.

This ensures that tips appear in the expected order when more than one of these components is rendered at the same time.
This commit is contained in:
Jarek Radosz 2024-10-14 09:54:01 +02:00 committed by GitHub
parent bf773e70bd
commit a3ea2886dc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
app/assets/javascripts/discourse/app/components/header/user-dropdown/notifications.gjs
View File

@ -64,6 +64,7 @@ export default class Notifications extends Component {
@titleText={{i18n "user_tips.first_notification.title"}} @titleText={{i18n "user_tips.first_notification.title"}}
@contentText={{i18n "user_tips.first_notification.content"}} @contentText={{i18n "user_tips.first_notification.content"}}
@showSkipButton={{true}} @showSkipButton={{true}}
@priority={{40}}
/> />
{{/if}} {{/if}}

1
app/assets/javascripts/discourse/app/components/suggested-topics.hbs
View File

@ -12,6 +12,7 @@
@titleText={{i18n "user_tips.suggested_topics.title"}} @titleText={{i18n "user_tips.suggested_topics.title"}}
@contentText={{i18n "user_tips.suggested_topics.content"}} @contentText={{i18n "user_tips.suggested_topics.content"}}
@placement="top-start" @placement="top-start"
@priority={{10}}
/> />
{{/unless}} {{/unless}}

1
app/assets/javascripts/discourse/app/components/topic-footer-buttons.hbs
View File

@ -97,6 +97,7 @@
@triggerSelector=".notifications-button" @triggerSelector=".notifications-button"
@titleText={{i18n "user_tips.topic_notification_levels.title"}} @titleText={{i18n "user_tips.topic_notification_levels.title"}}
@contentText={{i18n "user_tips.topic_notification_levels.content"}} @contentText={{i18n "user_tips.topic_notification_levels.content"}}
@priority={{20}}
/> />
{{/if}} {{/if}}

1
app/assets/javascripts/discourse/app/components/topic-timeline/container.hbs
View File

@ -67,6 +67,7 @@
@contentText={{i18n "user_tips.topic_timeline.content"}} @contentText={{i18n "user_tips.topic_timeline.content"}}
@placement="left" @placement="left"
@triggerSelector=".timeline-scrollarea-wrapper" @triggerSelector=".timeline-scrollarea-wrapper"
@priority={{30}}
/> />
<div class="timeline-scrollarea-wrapper"> <div class="timeline-scrollarea-wrapper">