github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-26 22:43:43 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Stop autocomplete for invalid usernames. (#7005)

Browse Source
This commit is contained in:
Dan Ungureanu 2019-02-15 02:29:26 +02:00 committed by Sam
parent f8b70f4ca3
commit a423a9383f
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/discourse/lib/user-search.js.es6
View File

@ -121,6 +121,10 @@ export default function userSearch(options) {
topicId = options.topicId, topicId = options.topicId,
group = options.group; group = options.group;
if (/[^\w.-]/.test(term)) {
term = "";
}
if (oldSearch) { if (oldSearch) {
oldSearch.abort(); oldSearch.abort();
oldSearch = null; oldSearch = null;

6
test/javascripts/lib/user-search-test.js.es6
View File

@ -1,4 +1,5 @@
import userSearch from "discourse/lib/user-search"; import userSearch from "discourse/lib/user-search";
import { CANCELLED_STATUS } from "discourse/lib/autocomplete";
QUnit.module("lib:user-search", { QUnit.module("lib:user-search", {
beforeEach() { beforeEach() {
@ -71,3 +72,8 @@ QUnit.test("it strips @ from the beginning", async assert => {
let results = await userSearch({ term: "@Team" }); let results = await userSearch({ term: "@Team" });
assert.equal(results[results.length - 1]["name"], "team"); assert.equal(results[results.length - 1]["name"], "team");
}); });
QUnit.test("it does not search for invalid usernames", async assert => {
let results = await userSearch({ term: "foo, " });
assert.equal(results, CANCELLED_STATUS);
});