eliminate cross talk in site setting test

spec/components/site_setting_extension_spec.rb

@@ -4,22 +4,27 @@ require_dependency 'site_settings/local_process_provider'
 
 describe SiteSettingExtension do
 
-  class FakeSettings
+
-    extend SiteSettingExtension
+  let :provider do
-    self.provider = SiteSettings::LocalProcessProvider.new
+    SiteSettings::LocalProcessProvider.new
   end
 
-  class FakeSettings2
+  def new_settings(provider)
-    extend SiteSettingExtension
+    c = Class.new
-    self.provider = FakeSettings.provider
+    c.class_eval do
+      extend SiteSettingExtension
+      self.provider = provider
+    end
+
+    c
   end
 
   let :settings do
-    FakeSettings
+    new_settings(provider)
   end
 
   let :settings2 do
-    FakeSettings2
+    new_settings(provider)
   end
 
   describe "refresh!" do