From a849bdf0c9cdd3dc96caa1170b213ff5f7d19216 Mon Sep 17 00:00:00 2001 From: Guo Xiang Tan Date: Thu, 14 May 2020 12:52:10 +0800 Subject: [PATCH] FIX: Don't publish typing presence if composer isn't opened. Hitting cancel on composer will set composer's reply and title to null causing our observer to fire. --- .../discourse/components/composer-presence-display.js.es6 | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/plugins/discourse-presence/assets/javascripts/discourse/components/composer-presence-display.js.es6 b/plugins/discourse-presence/assets/javascripts/discourse/components/composer-presence-display.js.es6 index 110bfb49d35..39e7e8ebf77 100644 --- a/plugins/discourse-presence/assets/javascripts/discourse/components/composer-presence-display.js.es6 +++ b/plugins/discourse-presence/assets/javascripts/discourse/components/composer-presence-display.js.es6 @@ -62,7 +62,10 @@ export default Component.extend({ _typing() { const action = this.get("model.action"); - if (action !== REPLY && action !== EDIT) { + if ( + (action !== REPLY && action !== EDIT) || + !this.get("model.composerOpened") + ) { return; }