github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 05:01:05 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Clean up d-toggle-switch (#29385)

Browse Source 
move the template to the bottom, inline `checked`, remove unnecessary `template-lint-disable`
This commit is contained in:
Jarek Radosz 2024-10-24 01:38:55 +02:00 committed by GitHub
parent 98a3e7d6e2
commit ab7547eb7a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
app/assets/javascripts/discourse/app/components/d-toggle-switch.gjs
View File

@ -3,18 +3,23 @@ import icon from "discourse-common/helpers/d-icon";
import I18n from "discourse-i18n";
export default class DToggleSwitch extends Component {
get computedLabel() {
if (this.args.label) {
return I18n.t(this.args.label);
}
return this.args.translatedLabel;
}
<template>
<div class="d-toggle-switch">
<label class="d-toggle-switch__label">
{{! template-lint-disable no-redundant-role }}
<button
class="d-toggle-switch__checkbox"
type="button"
role="switch"
aria-checked={{this.checked}}
aria-checked={{if @state "true" "false"}}
...attributes
></button>
{{! template-lint-enable no-redundant-role }}
<span class="d-toggle-switch__checkbox-slider">
{{#if @state}}
@ -30,15 +35,4 @@ export default class DToggleSwitch extends Component {
{{/if}}
</div>
</template>
get computedLabel() {
if (this.args.label) {
return I18n.t(this.args.label);
}
return this.args.translatedLabel;
}
get checked() {
return this.args.state ? "true" : "false";
}
}