github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-12-01 18:35:11 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Fix flaky test with bulk select closing topics (#29871)

Browse Source 
This commit is going to try using the `have_read_post` page object from
`topic_view` instead of the page object for `topic` because it's
implementation has a longer wait time as it uses the ENV variable for
wait time: `Capybara.default_max_wait_time * 2`.

If this works out we should probably remove the duplicated
`have_read_post` page object so that we have a single implementation.
This commit is contained in:
Blake Erickson 2024-11-20 16:34:44 -07:00 committed by GitHub
parent 34e6c8f3dd
commit acc87202b9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
spec/system/topic_bulk_select_spec.rb
View File

@ -9,6 +9,7 @@ describe "Topic bulk select", type: :system do
let(:topic_list) { PageObjects::Components::TopicList.new } let(:topic_list) { PageObjects::Components::TopicList.new }
let(:topic_page) { PageObjects::Pages::Topic.new } let(:topic_page) { PageObjects::Pages::Topic.new }
let(:topic_bulk_actions_modal) { PageObjects::Modals::TopicBulkActions.new } let(:topic_bulk_actions_modal) { PageObjects::Modals::TopicBulkActions.new }
let(:topic_view) { PageObjects::Components::TopicView.new }
def open_bulk_actions_modal(topics_to_select = nil, action) def open_bulk_actions_modal(topics_to_select = nil, action)
topic_list_header.click_bulk_select_button topic_list_header.click_bulk_select_button
@ -219,7 +220,7 @@ describe "Topic bulk select", type: :system do
sign_in(user) sign_in(user)
topic = topics.first topic = topics.first
visit("/t/#{topic.slug}/#{topic.id}") visit("/t/#{topic.slug}/#{topic.id}")
expect(topic_page).to have_read_post(1) expect(topic_view).to have_read_post(topic.posts.first)
topic_page.watch_topic topic_page.watch_topic
# Bulk close the topic as an admin # Bulk close the topic as an admin