github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-05 05:18:55 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

UX: banner enabled/disabled posts should be small posts, not full-size posts

Browse Source
This commit is contained in:
Neil Lalonde 2017-03-16 17:31:27 -04:00
parent 63c8b23690
commit ad8a579c79
3 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/widgets/post-small-action.js.es6
View File

@ -16,6 +16,8 @@ const icons = {
'pinned.disabled': 'thumb-tack unpinned', 'pinned.disabled': 'thumb-tack unpinned',
'pinned_globally.enabled': 'thumb-tack', 'pinned_globally.enabled': 'thumb-tack',
'pinned_globally.disabled': 'thumb-tack unpinned', 'pinned_globally.disabled': 'thumb-tack unpinned',
'banner.enabled': 'thumb-tack',
'banner.disabled': 'thumb-tack unpinned',
'visible.enabled': 'eye', 'visible.enabled': 'eye',
'visible.disabled': 'eye-slash', 'visible.disabled': 'eye-slash',
'split_topic': 'sign-out', 'split_topic': 'sign-out',

4
app/models/topic.rb
View File

@ -833,7 +833,7 @@ SQL
.update_all(dismissed_banner_key: nil) .update_all(dismissed_banner_key: nil)
self.archetype = Archetype.banner self.archetype = Archetype.banner
self.add_moderator_post(user, I18n.t("archetypes.banner.message.make")) self.add_small_action(user, "banner.enabled")
self.save self.save
MessageBus.publish('/site/banner', banner) MessageBus.publish('/site/banner', banner)
@ -841,7 +841,7 @@ SQL
def remove_banner!(user) def remove_banner!(user)
self.archetype = Archetype.default self.archetype = Archetype.default
self.add_moderator_post(user, I18n.t("archetypes.banner.message.remove")) self.add_small_action(user, "banner.disabled")
self.save self.save
MessageBus.publish('/site/banner', nil) MessageBus.publish('/site/banner', nil)

3
config/locales/client.en.yml
View File

@ -162,6 +162,9 @@ en:
visible: visible:
enabled: 'listed %{when}' enabled: 'listed %{when}'
disabled: 'unlisted %{when}' disabled: 'unlisted %{when}'
banner:
enabled: 'made this a banner %{when}. It will appear at the top of every page until it is dismissed by the user.'
disabled: 'removed this banner %{when}. It will no longer appear at the top of every page.'
topic_admin_menu: "topic admin actions" topic_admin_menu: "topic admin actions"