diff --git a/.eslintrc b/.eslintrc index 19d38e35c77..71e21b4381a 100644 --- a/.eslintrc +++ b/.eslintrc @@ -46,6 +46,7 @@ "expandSelectBox":true, "collapseSelectBox":true, "selectBoxSelectRow":true, + "selectBoxSelectNoneRow":true, "selectBoxFillInFilter":true, "asyncTestDiscourse":true, "fixture":true, diff --git a/app/assets/javascripts/admin/components/list-setting.js.es6 b/app/assets/javascripts/admin/components/list-setting.js.es6 index da6c5173d60..9a1d865133d 100644 --- a/app/assets/javascripts/admin/components/list-setting.js.es6 +++ b/app/assets/javascripts/admin/components/list-setting.js.es6 @@ -50,5 +50,3 @@ export default Ember.Component.extend({ }); } }); - - diff --git a/app/assets/javascripts/admin/templates/badges-show.hbs b/app/assets/javascripts/admin/templates/badges-show.hbs index e40e6bfec08..c9fe0496c1a 100644 --- a/app/assets/javascripts/admin/templates/badges-show.hbs +++ b/app/assets/javascripts/admin/templates/badges-show.hbs @@ -26,9 +26,7 @@ {{combo-box name="badge_type_id" value=buffered.badge_type_id content=badgeTypes - optionValuePath="content.id" - optionLabelPath="content.name" - disabled=readOnly}} + isDisabled=readOnly}}
@@ -36,8 +34,7 @@ {{combo-box name="badge_grouping_id" value=buffered.badge_grouping_id content=badgeGroupings - optionValuePath="content.id" - optionLabelPath="content.displayName"}} + nameProperty="name"}}  
diff --git a/app/assets/javascripts/admin/templates/components/admin-user-field-item.hbs b/app/assets/javascripts/admin/templates/components/admin-user-field-item.hbs index c5620d84edf..419ef0b69cf 100644 --- a/app/assets/javascripts/admin/templates/components/admin-user-field-item.hbs +++ b/app/assets/javascripts/admin/templates/components/admin-user-field-item.hbs @@ -1,6 +1,6 @@ {{#if editing}} {{#admin-form-row label="admin.user_fields.type"}} - {{combo-box content=fieldTypes valueAttribute="id" value=buffered.field_type}} + {{combo-box content=fieldTypes value=buffered.field_type}} {{/admin-form-row}} {{#admin-form-row label="admin.user_fields.name"}} diff --git a/app/assets/javascripts/admin/templates/components/embeddable-host.hbs b/app/assets/javascripts/admin/templates/components/embeddable-host.hbs index 88317ecd187..e21685831b5 100644 --- a/app/assets/javascripts/admin/templates/components/embeddable-host.hbs +++ b/app/assets/javascripts/admin/templates/components/embeddable-host.hbs @@ -9,7 +9,7 @@ {{input value=buffered.path_whitelist placeholder="/blog/.*" enter="save" class="path-whitelist"}} - {{category-select-box value=categoryId class="small"}} + {{category-chooser value=categoryId class="small"}} {{d-button icon="check" action="save" class="btn-primary" disabled=cantSave}} diff --git a/app/assets/javascripts/admin/templates/customize-themes-show.hbs b/app/assets/javascripts/admin/templates/customize-themes-show.hbs index 6b02429d77d..6f8ac614aaf 100644 --- a/app/assets/javascripts/admin/templates/customize-themes-show.hbs +++ b/app/assets/javascripts/admin/templates/customize-themes-show.hbs @@ -36,8 +36,7 @@

{{i18n "admin.customize.theme.color_scheme"}}

{{i18n "admin.customize.theme.color_scheme_select"}}

-

{{select-box content=colorSchemes - textKey="name" +

{{combo-box content=colorSchemes filterable=true value=colorSchemeId icon="paint-brush"}} @@ -123,11 +122,8 @@ {{/unless}} {{#if selectableChildThemes}} -

{{combo-box content=selectableChildThemes - nameProperty="name" - value=selectedChildThemeId - valueAttribute="id"}} - +

+ {{combo-box content=selectableChildThemes value=selectedChildThemeId}} {{#d-button action="addChildTheme" icon="plus"}}{{i18n "admin.customize.theme.add"}}{{/d-button}}

{{/if}} diff --git a/app/assets/javascripts/admin/templates/groups-bulk.hbs b/app/assets/javascripts/admin/templates/groups-bulk.hbs index baf3a63cda0..337ab37cb3e 100644 --- a/app/assets/javascripts/admin/templates/groups-bulk.hbs +++ b/app/assets/javascripts/admin/templates/groups-bulk.hbs @@ -6,7 +6,7 @@
- {{combo-box content=groups valueAttribute="id" value=groupId none="admin.groups.bulk_select"}} + {{combo-box filterable=true content=groups value=groupId none="admin.groups.bulk_select"}}
diff --git a/app/assets/javascripts/admin/templates/logs/staff-action-logs.hbs b/app/assets/javascripts/admin/templates/logs/staff-action-logs.hbs index 50f02f9f5b1..c44edc1a3e2 100644 --- a/app/assets/javascripts/admin/templates/logs/staff-action-logs.hbs +++ b/app/assets/javascripts/admin/templates/logs/staff-action-logs.hbs @@ -30,7 +30,7 @@ {{/if}}
{{else}} - {{i18n "admin.logs.staff_actions.filter"}} {{combo-box content=userHistoryActions nameProperty="name" value=filterActionId none="admin.logs.staff_actions.all"}} + {{i18n "admin.logs.staff_actions.filter"}} {{combo-box content=userHistoryActions value=filterActionId none="admin.logs.staff_actions.all"}} {{/if}}
diff --git a/app/assets/javascripts/admin/templates/modal/admin-color-scheme-select-base.hbs b/app/assets/javascripts/admin/templates/modal/admin-color-scheme-select-base.hbs index d58a63c1342..13169426341 100644 --- a/app/assets/javascripts/admin/templates/modal/admin-color-scheme-select-base.hbs +++ b/app/assets/javascripts/admin/templates/modal/admin-color-scheme-select-base.hbs @@ -2,7 +2,6 @@ {{#d-modal-body title="admin.customize.colors.select_base.title"}} {{i18n "admin.customize.colors.select_base.description"}} {{combo-box content=model - nameProperty="name" value=selectedBaseThemeId valueAttribute="base_scheme_id"}} {{/d-modal-body}} diff --git a/app/assets/javascripts/admin/templates/reports.hbs b/app/assets/javascripts/admin/templates/reports.hbs index 57acba8f502..3927d1e384f 100644 --- a/app/assets/javascripts/admin/templates/reports.hbs +++ b/app/assets/javascripts/admin/templates/reports.hbs @@ -4,10 +4,10 @@ {{i18n 'admin.dashboard.reports.start_date'}} {{date-picker-past value=startDate defaultDate=startDate}} {{i18n 'admin.dashboard.reports.end_date'}} {{date-picker-past value=endDate defaultDate=endDate}} {{#if showCategoryOptions}} - {{combo-box valueAttribute="value" content=categoryOptions value=categoryId}} + {{combo-box filterable=true valueAttribute="value" content=categoryOptions value=categoryId}} {{/if}} {{#if showGroupOptions}} - {{combo-box valueAttribute="value" content=groupOptions value=groupId}} + {{combo-box filterable=true valueAttribute="value" content=groupOptions value=groupId}} {{/if}} {{d-button action="refreshReport" class="btn-primary" label="admin.dashboard.reports.refresh_report" icon="refresh"}} {{d-button action="exportCsv" label="admin.export_csv.button_text" icon="download"}} diff --git a/app/assets/javascripts/admin/templates/user-badges.hbs b/app/assets/javascripts/admin/templates/user-badges.hbs index 9977aca39d2..1f6bae617c9 100644 --- a/app/assets/javascripts/admin/templates/user-badges.hbs +++ b/app/assets/javascripts/admin/templates/user-badges.hbs @@ -16,7 +16,7 @@
- {{combo-box valueAttribute="id" value=selectedBadgeId content=grantableBadges nameProperty="name"}} + {{combo-box filterable=true value=selectedBadgeId content=grantableBadges}}