From afaa2d5417e1d1c274aee64ccae36ffc5f10d6df Mon Sep 17 00:00:00 2001
From: Jarek Radosz <jradosz@gmail.com>
Date: Mon, 15 Aug 2022 03:33:25 +0200
Subject: [PATCH] DEV: Fix localStorage test leakage (#17917)

We weren't clearing the store in all cases.
---
 app/assets/javascripts/discourse/tests/helpers/qunit-helpers.js | 1 -
 app/assets/javascripts/discourse/tests/setup-tests.js           | 1 +
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/assets/javascripts/discourse/tests/helpers/qunit-helpers.js b/app/assets/javascripts/discourse/tests/helpers/qunit-helpers.js
index 35660ee8c47..c23824b4557 100644
--- a/app/assets/javascripts/discourse/tests/helpers/qunit-helpers.js
+++ b/app/assets/javascripts/discourse/tests/helpers/qunit-helpers.js
@@ -159,7 +159,6 @@ export function testCleanup(container, app) {
     });
   }
 
-  localStorage.clear();
   User.resetCurrent();
   resetExtraClasses();
   clearOutletCache();
diff --git a/app/assets/javascripts/discourse/tests/setup-tests.js b/app/assets/javascripts/discourse/tests/setup-tests.js
index a4a539d2c89..fa2a89cbefe 100644
--- a/app/assets/javascripts/discourse/tests/setup-tests.js
+++ b/app/assets/javascripts/discourse/tests/setup-tests.js
@@ -319,6 +319,7 @@ export default function setupTests(config) {
     flushMap();
 
     MessageBus.unsubscribe("*");
+    localStorage.clear();
   });
 
   if (getUrlParameter("qunit_disable_auto_start") === "1") {