github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 09:12:45 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Allow enabling safe-mode even when missing required fields (#29310)

Browse Source 
When a user is missing required fields, they are required to fill those up before continuing to interact with the forum. This applies to admins as well.

We keep a whitelist of paths that can still be visited in this mode: FAQ, About, 2FA setup, and any admin route for admins.

We concluded that admins should still be able to enable safe mode even with missing required fields. Since plugins etc. can potentially mess with the ability to fill those up.
This commit is contained in:
Ted Johansson 2024-10-21 17:11:43 +08:00 committed by GitHub
parent 425643bbd8
commit b1321b985a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/assets/javascripts/discourse/app/services/restricted-routing.js
View File

@ -9,7 +9,7 @@ export default class RestrictedRouting extends Service {
}
isAllowedRoute(path) {
const alwaysAllowed = ["faq", "about", "tos", "privacy"];
const alwaysAllowed = ["faq", "about", "tos", "privacy", "safe-mode"];
if (alwaysAllowed.includes(path)) {
return true;

2
app/controllers/application_controller.rb
View File

@ -928,7 +928,7 @@ class ApplicationController < ActionController::Base
redirect_path = path("/u/#{current_user.encoded_username}/preferences/profile")
second_factor_path = path("/u/#{current_user.encoded_username}/preferences/second-factor")
allowed_paths = [redirect_path, second_factor_path, path("/admin")]
allowed_paths = [redirect_path, second_factor_path, path("/admin"), path("/safe-mode")]
if allowed_paths.none? { |p| request.fullpath.start_with?(p) }
rate_limiter = RateLimiter.new(current_user, "redirect_to_required_fields_log", 1, 24.hours)

10
spec/system/user_page/user_preferences_profile_spec.rb
View File

@ -77,5 +77,15 @@ describe "User preferences | Profile", type: :system do
expect(page).to have_current_path("/")
end
it "allows enabling safe-mode" do
visit("/safe-mode")
expect(page).to have_current_path("/safe-mode")
page.find("#btn-enter-safe-mode").click
expect(page).to have_current_path("/u/#{user.username}/preferences/profile")
end
end
end