github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 09:42:02 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: skip_jobs when seeding topics (#11289)

Browse Source 
Don't raise an exception when creating a post inside a transaction in import_mode.
This commit is contained in:
Régis Hanol 2020-11-19 17:31:21 +01:00 committed by GitHub
parent 7af061fafa
commit b143412be4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/post_creator.rb
View File

@ -199,8 +199,10 @@ class PostCreator
end
def create
if !Rails.env.test? && ActiveRecord::Base.connection.open_transactions > 0 && !@opts[:skip_jobs]
raise "You must use 'skip_jobs = true' when creating a post inside a transaction, otherwise jobs won't run properly."
if !Rails.env.test? && !@opts[:import_mode]
if ActiveRecord::Base.connection.open_transactions > 0 && !@opts[:skip_jobs]
raise "You must use 'skip_jobs = true' when creating a post inside a transaction, otherwise jobs won't run properly."
end
end
if valid?

2
lib/seed_data/topics.rb
View File

@ -131,6 +131,7 @@ module SeedData
Discourse.system_user,
title: title,
raw: raw,
skip_jobs: true,
skip_validations: true,
category: category&.id
)
@ -139,6 +140,7 @@ module SeedData
PostCreator.create!(
Discourse.system_user,
raw: first_reply_raw(title),
skip_jobs: true,
skip_validations: true,
topic_id: post.topic_id
)