mirror of
https://github.com/discourse/discourse.git
synced 2024-11-22 13:41:31 +08:00
PERF: Correct should_skip? logic in s3:upload
(#18862)
This task is supposed to skip uploading if the asset is already present in S3. However, when a bucket 'folder path' was configured, this logic was broken and so the assets would be re-uploaded every time. This commit fixes that logic to include the bucket 'folder path' in the check
This commit is contained in:
parent
38bb00edce
commit
b18ebc9648
|
@ -13,6 +13,7 @@ end
|
|||
def should_skip?(path)
|
||||
return false if ENV['FORCE_S3_UPLOADS']
|
||||
@existing_assets ||= Set.new(helper.list("assets/").map(&:key))
|
||||
path = File.join(helper.s3_bucket_folder_path, path) if helper.s3_bucket_folder_path
|
||||
@existing_assets.include?(path)
|
||||
end
|
||||
|
||||
|
|
Loading…
Reference in New Issue
Block a user