github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 01:47:22 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: title when YouTube is pasted as the title to composer (#12565)

Browse Source 
When the YouTube link is passed to the composer, it should extract the title.

https://meta.discourse.org/t/youtube-link-not-generate-title/183776
This commit is contained in:
Krzysztof Kotlarek 2021-04-01 10:16:14 +11:00 committed by GitHub
parent af879b7851
commit b317962fe2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 27 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/assets/javascripts/discourse/app/components/composer-title.js
View File

@ -164,8 +164,12 @@ export default Component.extend({
const heading = frag.querySelector("h3, h4");
if (heading && heading.textContent) {
this.changeTitle(heading.textContent);
const title =
(heading && heading.textContent) ||
(frag.firstElementChild && frag.firstElementChild.title);
if (title) {
this.changeTitle(title);
} else {
const firstTitle =
(frag.firstChild &&

11
app/assets/javascripts/discourse/tests/acceptance/composer-topic-links-test.js
View File

@ -52,6 +52,17 @@ acceptance("Composer topic featured links", function (needs) {
);
});
test("YouTube onebox with title", async function (assert) {
await visit("/");
await click("#create-topic");
await fillIn("#reply-title", "https://www.youtube.com/watch?v=dQw4w9WgXcQ");
assert.equal(
queryAll(".title-input input").val(),
"Rick Astley - Never Gonna Give You Up (Video)",
"title is from the oneboxed article"
);
});
test("no onebox result", async function (assert) {
await visit("/");
await click("#create-topic");

10
app/assets/javascripts/discourse/tests/helpers/create-pretender.js
View File

@ -850,6 +850,16 @@ export function applyDefaultHandlers(pretender) {
];
}
if (
request.queryParams.url === "https://www.youtube.com/watch?v=dQw4w9WgXcQ"
) {
return [
200,
{ "Content-Type": "application/html" },
'<img src="https://i.ytimg.com/vi/dQw4w9WgXcQ/maxresdefault.jpg" width="480" height="360" title="Rick Astley - Never Gonna Give You Up (Video)">',
];
}
if (request.queryParams.url.indexOf("/internal-page.html") > -1) {
return [
200,