From b337ae5ae9a5dced13e14a32c92ca7ba59cc9132 Mon Sep 17 00:00:00 2001 From: Jarek Radosz Date: Tue, 27 Feb 2024 11:25:11 +0100 Subject: [PATCH] DEV: Update chrome-launcher from 0.15.2 to 1.1.0 (#25909) --- lib/tasks/smoke_test.rake | 2 +- package.json | 2 +- test/{smoke_test.js => smoke-test.mjs} | 10 +++++----- yarn.lock | 18 +++++++++--------- 4 files changed, 16 insertions(+), 16 deletions(-) rename test/{smoke_test.js => smoke-test.mjs} (97%) diff --git a/lib/tasks/smoke_test.rake b/lib/tasks/smoke_test.rake index 98553da0238..cab344e3946 100644 --- a/lib/tasks/smoke_test.rake +++ b/lib/tasks/smoke_test.rake @@ -63,7 +63,7 @@ task "smoke:test" do node_arguments = [] node_arguments << "--inspect-brk" if ENV["DEBUG_NODE"] - node_arguments << "#{Rails.root}/test/smoke_test.js" + node_arguments << "#{Rails.root}/test/smoke-test.mjs" node_arguments << url IO diff --git a/package.json b/package.json index ef4dcec8fca..4dfbd855ca3 100644 --- a/package.json +++ b/package.json @@ -17,7 +17,7 @@ "ace-builds": "1.4.13", "chart.js": "3.5.1", "chartjs-plugin-datalabels": "2.2.0", - "chrome-launcher": "^0.15.1", + "chrome-launcher": "^1.1.0", "chrome-remote-interface": "^0.33.0", "concurrently": "^8.2.2", "diffhtml": "1.0.0-beta.30", diff --git a/test/smoke_test.js b/test/smoke-test.mjs similarity index 97% rename from test/smoke_test.js rename to test/smoke-test.mjs index 2d9df401090..83cf3d56676 100644 --- a/test/smoke_test.js +++ b/test/smoke-test.mjs @@ -3,7 +3,7 @@ const args = process.argv.slice(2); if (args.length < 1 || args.length > 2) { - console.log("Expecting: node {smoke_test.js} {url}"); + console.log("Expecting: node test/smoke-test.mjs {URL}"); process.exit(1); } @@ -11,13 +11,13 @@ const url = args[0]; console.log(`Starting Discourse Smoke Test for ${url}`); -const chromeLauncher = require("chrome-launcher"); -const puppeteer = require("puppeteer-core"); -const path = require("path"); +import { Launcher } from "chrome-launcher"; +import path from "path"; +import puppeteer from "puppeteer-core"; (async () => { const browser = await puppeteer.launch({ - executablePath: chromeLauncher.Launcher.getInstallations()[0], + executablePath: Launcher.getInstallations()[0], // when debugging locally setting the SHOW_BROWSER env variable can be very helpful headless: process.env.SHOW_BROWSER === undefined, args: ["--disable-local-storage", "--no-sandbox"], diff --git a/yarn.lock b/yarn.lock index 9e878daef4d..0cf9ab2edb2 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4549,15 +4549,15 @@ check-error@^1.0.2: optionalDependencies: fsevents "~2.3.2" -chrome-launcher@^0.15.1: - version "0.15.2" - resolved "https://registry.yarnpkg.com/chrome-launcher/-/chrome-launcher-0.15.2.tgz#4e6404e32200095fdce7f6a1e1004f9bd36fa5da" - integrity sha512-zdLEwNo3aUVzIhKhTtXfxhdvZhUghrnmkvcAq2NoDd+LeOHKf03H5jwZ8T/STsAlzyALkBVK552iaG1fGf1xVQ== +chrome-launcher@^1.1.0: + version "1.1.0" + resolved "https://registry.yarnpkg.com/chrome-launcher/-/chrome-launcher-1.1.0.tgz#b5fd371839618bfc38e36cab569ef07c93fc50bf" + integrity sha512-rJYWeEAERwWIr3c3mEVXwNiODPEdMRlRxHc47B1qHPOolHZnkj7rMv1QSUfPoG6MgatWj5AxSpnKKR4QEwEQIQ== dependencies: "@types/node" "*" escape-string-regexp "^4.0.0" is-wsl "^2.2.0" - lighthouse-logger "^1.0.0" + lighthouse-logger "^2.0.1" chrome-remote-interface@^0.33.0: version "0.33.0" @@ -8958,10 +8958,10 @@ levn@^0.4.1: prelude-ls "^1.2.1" type-check "~0.4.0" -lighthouse-logger@^1.0.0: - version "1.4.2" - resolved "https://registry.yarnpkg.com/lighthouse-logger/-/lighthouse-logger-1.4.2.tgz#aef90f9e97cd81db367c7634292ee22079280aaa" - integrity sha512-gPWxznF6TKmUHrOQjlVo2UbaL2EJ71mb2CCeRs/2qBpi4L/g4LUVc9+3lKQ6DTUZwJswfM7ainGrLO1+fOqa2g== +lighthouse-logger@^2.0.1: + version "2.0.1" + resolved "https://registry.yarnpkg.com/lighthouse-logger/-/lighthouse-logger-2.0.1.tgz#48895f639b61cca89346bb6f47f7403a3895fa02" + integrity sha512-ioBrW3s2i97noEmnXxmUq7cjIcVRjT5HBpAYy8zE11CxU9HqlWHHeRxfeN1tn8F7OEMVPIC9x1f8t3Z7US9ehQ== dependencies: debug "^2.6.9" marky "^1.2.2"