From b364de7387c1be0e99e726dc77fe5fe6d67da103 Mon Sep 17 00:00:00 2001 From: Alan Guo Xiang Tan Date: Tue, 19 Dec 2023 14:20:21 +0800 Subject: [PATCH] DEV: Revert `upload-artifacts` to v3 for flaky test related actions (#24960) Why this change? `upload-artifacts` v4 introduces a breaking change where uploading multiple uploads to the same name artifact is no longer supported. However, we have external services reading these artifacts and the change in the artifact name is breaking those services. --- .github/workflows/tests.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 234986f906a..cd6bec85af3 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -289,10 +289,10 @@ jobs: shell: bash - name: Upload failed system test screenshots - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 # TODO (tgxworld): V4 doesn't allow us to upload multiple uploads to the same artifact name so keep at V3 for now. if: always() && steps.check-failed-system-test-screenshots.outputs.exists == 'true' with: - name: failed-system-test-screenshots-${{ hashFiles('tmp/capybara/*.png') }} + name: failed-system-test-screenshots path: tmp/capybara/*.png - name: Check for flaky tests report @@ -318,10 +318,10 @@ jobs: run: cp tmp/turbo_rspec_flaky_tests.json tmp/turbo_rspec_flaky_tests-${{ matrix.build_type }}-${{ matrix.target }}-${{ steps.fetch-job-id.outputs.job_id }}.json - name: Upload flaky tests report - uses: actions/upload-artifact@v4 + uses: actions/upload-artifact@v3 # TODO (tgxworld): V4 doesn't allow us to upload multiple uploads to the same artifact name so keep at V3 for now if: always() && steps.check-flaky-spec-report.outputs.exists == 'true' with: - name: flaky-test-reports-${{ hashFiles('tmp/turbo_rspec_flaky_tests-*') }} + name: flaky-test-reports path: tmp/turbo_rspec_flaky_tests-${{ matrix.build_type }}-${{ matrix.target }}-${{ steps.fetch-job-id.outputs.job_id }}.json - name: Check Annotations