FEATURE: show tags in crawler view of tags page for static site

Previously tags page would have an empty page in crawler view
This commit is contained in:
Saurabh Patel 2019-06-06 08:25:37 +05:30 committed by Sam
parent c3a38d2304
commit b510006ca8
3 changed files with 80 additions and 31 deletions

View File

@ -27,6 +27,34 @@ class TagsController < ::ApplicationController
@description_meta = I18n.t("tags.title") @description_meta = I18n.t("tags.title")
@title = @description_meta @title = @description_meta
show_all_tags = guardian.can_admin_tags? && guardian.is_admin?
if SiteSetting.tags_listed_by_group
ungrouped_tags = Tag.where("tags.id NOT IN (SELECT tag_id FROM tag_group_memberships)")
ungrouped_tags = ungrouped_tags.where("tags.topic_count > 0") unless show_all_tags
grouped_tag_counts = TagGroup.visible(guardian).order('name ASC').includes(:tags).map do |tag_group|
{ id: tag_group.id, name: tag_group.name, tags: self.class.tag_counts_json(tag_group.tags) }
end
@tags = self.class.tag_counts_json(ungrouped_tags)
@extras = { tag_groups: grouped_tag_counts }
else
tags = show_all_tags ? Tag.all : Tag.where("tags.topic_count > 0")
unrestricted_tags = DiscourseTagging.filter_visible(tags, guardian)
categories = Category.where("id IN (SELECT category_id FROM category_tags)")
.where("id IN (?)", guardian.allowed_category_ids)
.includes(:tags)
category_tag_counts = categories.map do |c|
{ id: c.id, tags: self.class.tag_counts_json(c.tags) }
end
@tags = self.class.tag_counts_json(unrestricted_tags)
@extras = { categories: category_tag_counts }
end
respond_to do |format| respond_to do |format|
format.html do format.html do
@ -34,37 +62,10 @@ class TagsController < ::ApplicationController
end end
format.json do format.json do
show_all_tags = guardian.can_admin_tags? && guardian.is_admin? render json: {
tags: @tags,
if SiteSetting.tags_listed_by_group extras: @extras
ungrouped_tags = Tag.where("tags.id NOT IN (SELECT tag_id FROM tag_group_memberships)") }
ungrouped_tags = ungrouped_tags.where("tags.topic_count > 0") unless show_all_tags
grouped_tag_counts = TagGroup.visible(guardian).order('name ASC').includes(:tags).map do |tag_group|
{ id: tag_group.id, name: tag_group.name, tags: self.class.tag_counts_json(tag_group.tags) }
end
render json: {
tags: self.class.tag_counts_json(ungrouped_tags),
extras: { tag_groups: grouped_tag_counts }
}
else
tags = show_all_tags ? Tag.all : Tag.where("tags.topic_count > 0")
unrestricted_tags = DiscourseTagging.filter_visible(tags, guardian)
categories = Category.where("id IN (SELECT category_id FROM category_tags)")
.where("id IN (?)", guardian.allowed_category_ids)
.includes(:tags)
category_tag_counts = categories.map do |c|
{ id: c.id, tags: self.class.tag_counts_json(c.tags) }
end
render json: {
tags: self.class.tag_counts_json(unrestricted_tags),
extras: { categories: category_tag_counts }
}
end
end end
end end
end end

View File

@ -0,0 +1,6 @@
<div class="tag-box">
<a href="<%= Discourse.base_url %>/tags/<%= tag[:id] %>" class="discourse-tag simple"><%= tag[:text] %></a>
<% if tag[:count] && tag[:count] > 0 %>
<span class="tag-count">x <%= tag[:count] %></span>
<% end %>
</div>

View File

@ -1,3 +1,45 @@
<% content_for :head do %> <% content_for :head do %>
<%= raw crawlable_meta_data(title: @title, description: @description_meta) %> <%= raw crawlable_meta_data(title: @title, description: @description_meta) %>
<% end %> <% end %>
<div class="tag-crawler">
<% if @extras[:categories] %>
<% @extras[:categories].each do |category| %>
<div class="tag-list">
<% if category[:name] %>
<h3><%= category[:name] %></h3>
<% end %>
<% category[:tags].each do |tag| %>
<%= render "tag", tag: tag %>
<% end %>
</div>
<div class="clearfix"></div>
<% end %>
<% end %>
<% if @extras[:tag_groups] %>
<% @extras[:tag_groups].each do |tag_group| %>
<div class="tag-list">
<% if tag_group[:name] %>
<h3><%= tag_group[:name] %></h3>
<% end %>
<% tag_group[:tags].each do |tag| %>
<%= render "tag", tag: tag %>
<% end %>
</div>
<div class="clearfix"></div>
<% end %>
<% end %>
<% if @tags.present? %>
<div class="tag-list">
<h3><%= t 'js.tagging.other_tags' %></h3>
<% @tags.each do |tag| %>
<%= render "tag", tag: tag %>
<% end %>
</div>
<div class="clearfix"></div>
<% end %>
</div>