github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-25 15:49:23 +08:00
Code Issues Actions1 Packages Projects Releases Wiki Activity

UX: do not check for dimensions in video filename ()

Browse Source
This commit is contained in:
Kris 2024-08-15 11:59:13 -04:00 committed by GitHub
parent 1ca06e1283
commit b545576b3c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 1 deletions
app/assets/javascripts
discourse-markdown-it/src/features
image-controls.js
discourse/tests/acceptance
composer-image-preview-test.js

4
app/assets/javascripts/discourse-markdown-it/src/features/image-controls.js

@ -31,7 +31,9 @@ function isUpload(token) {
}
function hasMetadata(token) {
return token.content.match(/(\d{1,4}x\d{1,4})/);
return !!token.content
.split("|")
.find((part) => /^\d{1,4}x\d{1,4}(,\s*\d{1,3}%)?$/.test(part));
}
function appendMetaData(index, token) {

7
app/assets/javascripts/discourse/tests/acceptance/composer-image-preview-test.js

@ -141,6 +141,13 @@ acceptance("Composer - Image Preview", function (needs) {
`
);
// don't add controls to video uploads with dimensions in name
await fillIn(
".d-editor-input",
"![SampleVideo_1280x720|video](upload://test.mp4)"
);
assert.dom(".button-wrapper").doesNotExist();
assert.ok(
!exists("script"),
"it does not unescape script tags in code blocks"