github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-25 19:03:45 +08:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

FIX: Remove more computed properties being set

Browse Source 
Note: This also removes a test. The test had not properly stubbed its
request and was erroring in dev mode, and the test was relying on the
erronous result.
This commit is contained in:
Robin Ward 2020-07-16 16:06:27 -04:00
parent 6ba1c64130
commit b5735f98e9
1 changed files with 7 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
test/javascripts/acceptance/topic-edit-timer-test.js
View File

@ -20,7 +20,7 @@ acceptance("Topic - Edit timer", {
}); });
QUnit.test("default", async assert => { QUnit.test("default", async assert => {
updateCurrentUser({ moderator: true, canManageTopic: true }); updateCurrentUser({ moderator: true });
const timerType = selectKit(".select-kit.timer-type"); const timerType = selectKit(".select-kit.timer-type");
const futureDateInputSelector = selectKit(".future-date-input-selector"); const futureDateInputSelector = selectKit(".future-date-input-selector");
@ -41,7 +41,7 @@ QUnit.test("default", async assert => {
}); });
QUnit.test("autoclose - specific time", async assert => { QUnit.test("autoclose - specific time", async assert => {
updateCurrentUser({ moderator: true, canManageTopic: true }); updateCurrentUser({ moderator: true });
const futureDateInputSelector = selectKit(".future-date-input-selector"); const futureDateInputSelector = selectKit(".future-date-input-selector");
await visit("/t/internationalization-localization"); await visit("/t/internationalization-localization");
@ -67,7 +67,7 @@ QUnit.test("autoclose - specific time", async assert => {
}); });
QUnit.skip("autoclose", async assert => { QUnit.skip("autoclose", async assert => {
updateCurrentUser({ moderator: true, canManageTopic: true }); updateCurrentUser({ moderator: true });
const futureDateInputSelector = selectKit(".future-date-input-selector"); const futureDateInputSelector = selectKit(".future-date-input-selector");
await visit("/t/internationalization-localization"); await visit("/t/internationalization-localization");
@ -134,7 +134,7 @@ QUnit.skip("autoclose", async assert => {
}); });
QUnit.test("close temporarily", async assert => { QUnit.test("close temporarily", async assert => {
updateCurrentUser({ moderator: true, canManageTopic: true }); updateCurrentUser({ moderator: true });
const timerType = selectKit(".select-kit.timer-type"); const timerType = selectKit(".select-kit.timer-type");
const futureDateInputSelector = selectKit(".future-date-input-selector"); const futureDateInputSelector = selectKit(".future-date-input-selector");
@ -181,7 +181,7 @@ QUnit.test("close temporarily", async assert => {
}); });
QUnit.test("schedule", async assert => { QUnit.test("schedule", async assert => {
updateCurrentUser({ moderator: true, canManageTopic: true }); updateCurrentUser({ moderator: true });
const timerType = selectKit(".select-kit.timer-type"); const timerType = selectKit(".select-kit.timer-type");
const categoryChooser = selectKit(".modal-body .category-chooser"); const categoryChooser = selectKit(".modal-body .category-chooser");
const futureDateInputSelector = selectKit(".future-date-input-selector"); const futureDateInputSelector = selectKit(".future-date-input-selector");
@ -235,7 +235,7 @@ QUnit.test("TL4 can't auto-delete", async assert => {
}); });
QUnit.test("auto delete", async assert => { QUnit.test("auto delete", async assert => {
updateCurrentUser({ moderator: true, canManageTopic: true }); updateCurrentUser({ moderator: true });
const timerType = selectKit(".select-kit.timer-type"); const timerType = selectKit(".select-kit.timer-type");
const futureDateInputSelector = selectKit(".future-date-input-selector"); const futureDateInputSelector = selectKit(".future-date-input-selector");
@ -267,37 +267,8 @@ QUnit.test("auto delete", async assert => {
assert.ok(regex.test(html)); assert.ok(regex.test(html));
}); });
QUnit.test(
"Manually closing before the timer will clear the status text",
async assert => {
updateCurrentUser({ moderator: true, canManageTopic: true });
const futureDateInputSelector = selectKit(".future-date-input-selector");
await visit("/t/topic-for-group-moderators/2480");
await click(".toggle-admin-menu");
await click(".topic-admin-status-update button");
await futureDateInputSelector.expand();
await futureDateInputSelector.selectRowByValue("next_week");
await click(".modal-footer button.btn-primary");
const regex = /will automatically close in/g;
const topicStatusInfo = find(".topic-status-info")
.html()
.trim();
assert.ok(regex.test(topicStatusInfo));
await click(".toggle-admin-menu");
await click(".topic-admin-close button");
const newTopicStatusInfo = find(".topic-status-info")
.html()
.trim();
assert.notOk(regex.test(newTopicStatusInfo));
}
);
QUnit.test("Inline delete timer", async assert => { QUnit.test("Inline delete timer", async assert => {
updateCurrentUser({ moderator: true, canManageTopic: true }); updateCurrentUser({ moderator: true });
const futureDateInputSelector = selectKit(".future-date-input-selector"); const futureDateInputSelector = selectKit(".future-date-input-selector");
await visit("/t/internationalization-localization"); await visit("/t/internationalization-localization");