github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-26 12:05:39 +08:00
Code Issues Actions1 Packages Projects Releases Wiki Activity

Revert "UX: Hide user menu bookmark link when experimental sidebar is enabled ()" ()

Browse Source 
This reverts commit 526e6e7a3b1a6edb35dcb124ef642ea23a756eef.

Link in dropdown user menu is kept in favor of link in experimental sidebar
This commit is contained in:
Alan Guo Xiang Tan 2022-07-08 15:44:49 +08:00 committed by GitHub
parent 94c70a0909
commit b622302351
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 18 deletions
app/assets/javascripts/discourse
app/widgets
user-menu.js
tests/integration/widgets
user-menu-test.js

4
app/assets/javascripts/discourse/app/widgets/user-menu.js

@ -153,9 +153,7 @@ createWidget("user-menu-links", {
});
}
if (!this.currentUser.experimental_sidebar_enabled) {
glyphs.push(this.bookmarksGlyph());
}
glyphs.push(this.bookmarksGlyph());
if (this.siteSettings.enable_personal_messages || this.currentUser.staff) {
glyphs.push(this.messagesGlyph());

15
app/assets/javascripts/discourse/tests/integration/widgets/user-menu-test.js

@ -154,21 +154,6 @@ discourseModule(
},
});
componentTest("bookmarks - experimental sidebar enabled", {
template: hbs`{{mount-widget widget="user-menu"}}`,
beforeEach() {
this.currentUser.setProperties({ experimental_sidebar_enabled: true });
},
async test(assert) {
assert.notOk(
exists(".user-bookmarks-link"),
"user bookmark link is not displayed"
);
},
});
componentTest("bookmarks", {
template: hbs`{{mount-widget widget="user-menu"}}`,