github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-26 18:33:52 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: resets user search cache between tests (#13873)

Browse Source 
The current behaviour was producing random tests failures which where consistently reproducible using `seed=32037592518471299633729129648744282271`

The cause of this error, is a previous test not giving any topicId or categoryId resulting in a cache key "undefined-undefined", just like a possibly previous test. Reseting cache between tests, seems the most straightforward and future proof solution
This commit is contained in:
Joffrey JAFFEUX 2021-07-28 15:32:49 +02:00 committed by GitHub
parent 2818ebd19f
commit b673fee946
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/assets/javascripts/discourse/app/lib/user-search.js
View File

@ -12,6 +12,14 @@ let cache = {},
currentTerm, currentTerm,
oldSearch; oldSearch;
export function resetUserSearchCache() {
cache = {};
cacheKey = null;
cacheTime = null;
currentTerm = null;
oldSearch = null;
}
function performSearch( function performSearch(
term, term,
topicId, topicId,

2
app/assets/javascripts/discourse/tests/helpers/qunit-helpers.js
View File

@ -34,6 +34,7 @@ import { resetDecorators as resetPostCookedDecorators } from "discourse/widgets/
import { resetTopicTitleDecorators } from "discourse/components/topic-title"; import { resetTopicTitleDecorators } from "discourse/components/topic-title";
import { resetUsernameDecorators } from "discourse/helpers/decorate-username-selector"; import { resetUsernameDecorators } from "discourse/helpers/decorate-username-selector";
import { resetWidgetCleanCallbacks } from "discourse/components/mount-widget"; import { resetWidgetCleanCallbacks } from "discourse/components/mount-widget";
import { resetUserSearchCache } from "discourse/lib/user-search";
import sessionFixtures from "discourse/tests/fixtures/session-fixtures"; import sessionFixtures from "discourse/tests/fixtures/session-fixtures";
import { setTopicList } from "discourse/lib/topic-list-tracker"; import { setTopicList } from "discourse/lib/topic-list-tracker";
import sinon from "sinon"; import sinon from "sinon";
@ -272,6 +273,7 @@ export function acceptance(name, optionsOrCallback) {
resetUsernameDecorators(); resetUsernameDecorators();
resetOneboxCache(); resetOneboxCache();
resetCustomPostMessageCallbacks(); resetCustomPostMessageCallbacks();
resetUserSearchCache();
clearCustomNavItemHref(); clearCustomNavItemHref();
setTopicList(null); setTopicList(null);
_clearSnapshots(); _clearSnapshots();