github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-04-03 05:39:41 +08:00
Code Issues Actions1 Packages Projects Releases Wiki Activity

FIX: need to require open-uri for discourse-narrative-bot plugin

Browse Source 
By requiring open-uri this will fix the following error:

```
NoMethodError (private method `open' called for #<URI::Generic...
```

also switched to the shorter syntax and removed default options. Since
ruby 2.4 redirect is on by default.
This commit is contained in:
Blake Erickson 2019-11-13 18:05:55 -07:00
parent 03efbad932
commit b69450bee2
1 changed files with 3 additions and 1 deletions

4
plugins/discourse-narrative-bot/plugin.rb

@ -6,6 +6,8 @@
# authors: Nick Sahler, Alan Tan # authors: Nick Sahler, Alan Tan
# url: https://github.com/discourse/discourse/tree/master/plugins/discourse-narrative-bot # url: https://github.com/discourse/discourse/tree/master/plugins/discourse-narrative-bot
require 'open-uri'
enabled_site_setting :discourse_narrative_bot_enabled enabled_site_setting :discourse_narrative_bot_enabled
hide_plugin if self.respond_to?(:hide_plugin) hide_plugin if self.respond_to?(:hide_plugin)
@ -109,7 +111,7 @@ after_initialize do
def fetch_avatar_url(user) def fetch_avatar_url(user)
avatar_url = UrlHelper.absolute(Discourse.base_uri + user.avatar_template.gsub('{size}', '250')) avatar_url = UrlHelper.absolute(Discourse.base_uri + user.avatar_template.gsub('{size}', '250'))
URI(avatar_url).open('rb', redirect: true, allow_redirections: :all).read open(avatar_url, 'rb').read
rescue OpenURI::HTTPError rescue OpenURI::HTTPError
# Ignore if fetching image returns a non 200 response # Ignore if fetching image returns a non 200 response
end end