github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 11:44:49 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: empty state message on the group messages pages (#14371)

Browse Source
This commit is contained in:
Andrei Prigorshnev 2021-09-20 07:38:57 +04:00 committed by GitHub
parent a842ea8e6e
commit b6ccc9c37a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
app/assets/javascripts/discourse/app/routes/build-private-messages-group-route.js
View File

@ -1,5 +1,5 @@
import I18n from "I18n";
import createPMRoute from "discourse/routes/build-private-messages-route";
import I18n from "I18n";
import { findOrResetCachedTopicList } from "discourse/lib/cached-topic-list";
export default (inboxType, filter) => {
@ -35,7 +35,16 @@ export default (inboxType, filter) => {
return lastTopicList
? lastTopicList
: this.store.findFiltered("topicList", { filter: topicListFilter });
: this.store
.findFiltered("topicList", { filter: topicListFilter })
.then((topicList) => {
// andrei: we agreed that this is an anti pattern,
// it's better to avoid mutating a rest model like this
// this place we'll be refactored later
// see https://github.com/discourse/discourse/pull/14313#discussion_r708784704
topicList.set("emptyState", this.emptyState());
return topicList;
});
},
afterModel(model) {
@ -69,6 +78,13 @@ export default (inboxType, filter) => {
this.controllerFor("user-private-messages").set("group", this.group);
},
emptyState() {
return {
title: I18n.t("user.no_messages_title"),
body: "",
};
},
dismissReadOptions() {
return {
group_name: this.get("groupName"),