github-mirror/discourse
github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-03-16 04:45:40 +08:00
Code Issues Actions1 Packages Projects Releases Wiki Activity

A11Y: Bookmarks modal ()

Browse Source 
* A11Y: Add label to delete button

* A11Y: Add title attribute to options button
This commit is contained in:
Keegan George 2022-10-17 18:34:02 -07:00 committed by GitHub
parent 7881a6bd2f
commit b8fcf1932e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions

4
app/assets/javascripts/discourse/app/templates/components/bookmark.hbs

@ -9,7 +9,7 @@
<div class="control-group bookmark-name-wrap"> <div class="control-group bookmark-name-wrap">
<Input id="bookmark-name" @value={{this.model.name}} name="bookmark-name" class="bookmark-name" @enter={{action "saveAndClose"}} placeholder={{i18n "post.bookmarks.name_placeholder"}} maxlength="100" /> <Input id="bookmark-name" @value={{this.model.name}} name="bookmark-name" class="bookmark-name" @enter={{action "saveAndClose"}} placeholder={{i18n "post.bookmarks.name_placeholder"}} maxlength="100" />
<DButton @icon="cog" @action={{action "toggleShowOptions"}} @class="bookmark-options-button" @ariaLabel="post.bookmarks.options" /> <DButton @icon="cog" @action={{action "toggleShowOptions"}} @class="bookmark-options-button" @ariaLabel="post.bookmarks.options" @title="post.bookmarks.options" />
</div> </div>
{{#if this.showOptions}} {{#if this.showOptions}}
@ -42,7 +42,7 @@
<DButton @id="save-bookmark" @label="bookmarks.save" @class="btn-primary" @action={{action "saveAndClose"}} /> <DButton @id="save-bookmark" @label="bookmarks.save" @class="btn-primary" @action={{action "saveAndClose"}} />
<DModalCancel @close={{action "closeWithoutSavingBookmark"}} /> <DModalCancel @close={{action "closeWithoutSavingBookmark"}} />
{{#if this.showDelete}} {{#if this.showDelete}}
<DButton @id="delete-bookmark" @icon="trash-alt" @class="delete-bookmark btn-danger" @action={{action "delete"}} /> <DButton @id="delete-bookmark" @icon="trash-alt" @class="delete-bookmark btn-danger" @action={{action "delete"}} @ariaLabel="post.bookmarks.actions.delete_bookmark.name" @title="post.bookmarks.actions.delete_bookmark.name" />
{{/if}} {{/if}}
</div> </div>
</ConditionalLoadingSpinner> </ConditionalLoadingSpinner>