github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 03:16:41 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Do not track a elements with no href.

Browse Source
This commit is contained in:
Bianca Nenciu 2019-04-23 23:13:23 +03:00
parent b81d169e2a
commit b9339e15a1
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
app/assets/javascripts/discourse/lib/click-track.js.es6
View File

@ -10,7 +10,11 @@ export function isValidLink($link) {
// - links with disabled tracking
// - category links
// - quote back button
if ($link.is(".lightbox, .mention, .mention-group, .no-track-link, .hashtag, .back")) {
if (
$link.is(
".lightbox, .mention, .mention-group, .no-track-link, .hashtag, .back"
)
) {
return false;
}
@ -63,10 +67,8 @@ export default {
return true;
}
let href = ($link.attr("href") || $link.data("href")).trim();
if (!href) {
return false;
} else if (href.indexOf("mailto:") === 0) {
let href = ($link.attr("href") || $link.data("href") || "").trim();
if (!href || href.indexOf("mailto:") === 0) {
return true;
}