github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-20 10:56:15 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Skip notifications without topic_id in ensure_consistency (#16299)

Browse Source
This commit is contained in:
Mark VanLandingham 2022-03-30 09:56:35 -05:00 committed by GitHub
parent 2e77cc86fc
commit b974375239
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/models/notification.rb
View File

@ -64,7 +64,7 @@ class Notification < ActiveRecord::Base
DELETE
FROM notifications n
WHERE high_priority
AND notification_type NOT IN (#{types[:chat_mention].to_i}, #{types[:chat_message].to_i})
AND n.topic_id IS NOT NULL
AND NOT EXISTS (
SELECT 1
FROM posts p

5
spec/models/notification_spec.rb
View File

@ -340,10 +340,9 @@ describe Notification do
expect(Notification.count).to eq(2)
end
it 'does not delete chat_message notifications' do
it 'does not delete notifications that do not have a topic_id' do
Notification.create!(read: false, user_id: user.id, topic_id: nil, post_number: nil, data: '[]',
notification_type: Notification.types[:chat_mention])
notification_type: Notification.types[:chat_mention], high_priority: true)
expect {
Notification.ensure_consistency!
}.to_not change { Notification.count }