From baaa3e0f9f6b436aa2ac2cd6ad1e6d8a47d74017 Mon Sep 17 00:00:00 2001 From: Sam Date: Mon, 18 Aug 2014 14:40:54 +1000 Subject: [PATCH] FIX: #2664 it should be validates not validate Thanks @chancancode --- app/controllers/admin/groups_controller.rb | 4 ++-- app/models/group.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/controllers/admin/groups_controller.rb b/app/controllers/admin/groups_controller.rb index 6347a0a00f9..21920d8a587 100644 --- a/app/controllers/admin/groups_controller.rb +++ b/app/controllers/admin/groups_controller.rb @@ -23,12 +23,12 @@ class Admin::GroupsController < Admin::AdminController def update group = Group.find(params[:id].to_i) + group.alias_level = params[:group][:alias_level].to_i if params[:group][:alias_level].present? + if group.automatic # we can only change the alias level on automatic groups - group.alias_level = params[:group][:alias_level] else group.usernames = params[:group][:usernames] - group.alias_level = params[:group][:alias_level] group.name = params[:group][:name] if params[:group][:name] end group.visible = params[:group][:visible] == "true" diff --git a/app/models/group.rb b/app/models/group.rb index cea58d00912..6fa81ac2797 100644 --- a/app/models/group.rb +++ b/app/models/group.rb @@ -34,7 +34,7 @@ class Group < ActiveRecord::Base :everyone => 99 } - validate :alias_level, inclusion: { in: ALIAS_LEVELS.values} + validates :alias_level, inclusion: { in: ALIAS_LEVELS.values} def posts_for(guardian, before_post_id=nil) user_ids = group_users.map {|gu| gu.user_id}