github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-23 03:09:00 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: Improve PageObjects::Modals::SidebarEditTags#has_tag_checkboxes? (#22407)

Browse Source 
Why this change?

Improves the error message when stuff fails.

Before:

expected `#<PageObjects::Modals::SidebarEditTags:0x00007fa3877135e0>.has_tag_checkboxes?([#<Tag id: 1, name: "tag", created_at: "2023-07-04 05:21:12.914149000 +0000", updated_at: "2023-07-04..._topic_count: 0, target_tag_id: nil, description: nil, public_topic_count: 1, staff_topic_count: 1>])` to be truthy, got false

After:

expected to find visible css ".sidebar-tags-form .sidebar-tags-form__tag-label-name" 3 times, found 4 matches: "tag", "tag2", "tag3", "tag4"
This commit is contained in:
Alan Guo Xiang Tan 2023-07-04 13:51:23 +08:00 committed by GitHub
parent 454a4af0bf
commit bb0698858f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
spec/system/page_objects/modals/sidebar_edit_tags.rb
View File

@ -6,12 +6,10 @@ module PageObjects
module Modals
class SidebarEditTags < SidebarEditNavigationModal
def has_tag_checkboxes?(tags)
tag_names = tags.map(&:name)
tag_checkboxes =
all(".sidebar-tags-form .sidebar-tags-form__tag-label-name", count: tags.length)
has_css?(".sidebar-tags-form .sidebar-tags-form__tag", count: tag_names.length) &&
all(".sidebar-tags-form .sidebar-tags-form__tag").all? do |row|
tag_names.include?(row["data-tag-name"].to_s)
end
expect(tag_checkboxes.map(&:text)).to eq(tags.map(&:name))
end
def has_no_tag_checkboxes?