github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 12:12:26 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: migrate audio cloak-prevention to decorateCookedElement (#15502)

Browse Source 
Migrate deprecated decorateCooked to decorateCookedElement for audio cloak-prevention.

This might give a minimal performance boost: running audio cloak-prevention for 20 (non-audio) posts takes 1 ms and not 15 ms.

Co-authored-by: Jarek Radosz <jradosz@gmail.com>
This commit is contained in:
Ayke Halder 2022-01-09 01:57:49 +01:00 committed by GitHub
parent 5a50f18c0c
commit c0d702f01f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
app/assets/javascripts/discourse/app/initializers/post-decorations.js
View File

@ -39,20 +39,19 @@ export default {
nativeLazyLoading(api);
api.decorateCooked(
($elem) => {
const players = $("audio", $elem);
if (players.length) {
players.on("play", () => {
api.decorateCookedElement(
(elem) => {
elem.querySelectorAll("audio").forEach((player) => {
player.addEventListener("play", () => {
const postId = parseInt(
$elem.closest("article").data("post-id"),
elem.closest("article")?.dataset.postId,
10
);
if (postId) {
api.preventCloak(postId);
}
});
}
});
},
{ id: "discourse-audio" }
);