github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-17 12:42:47 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

DEV: improve the code readability.

Browse Source 
82c5a1d20f
This commit is contained in:
Vinoth Kannan 2019-09-06 01:27:29 +05:30
parent d78ed3159d
commit c1769b0ec5
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/discourse/components/groups-form-membership-fields.js.es6
View File

@ -19,12 +19,12 @@ export default Ember.Component.extend({
@computed("model.visibility_level", "model.public_admission") @computed("model.visibility_level", "model.public_admission")
disableMembershipRequestSetting(visibility_level, publicAdmission) { disableMembershipRequestSetting(visibility_level, publicAdmission) {
visibility_level = parseInt(visibility_level); visibility_level = parseInt(visibility_level);
return ![0, 1].includes(visibility_level) || publicAdmission; return publicAdmission || visibility_level > 1;
}, },
@computed("model.visibility_level", "model.allow_membership_requests") @computed("model.visibility_level", "model.allow_membership_requests")
disablePublicSetting(visibility_level, allowMembershipRequests) { disablePublicSetting(visibility_level, allowMembershipRequests) {
visibility_level = parseInt(visibility_level); visibility_level = parseInt(visibility_level);
return ![0, 1].includes(visibility_level) || allowMembershipRequests; return allowMembershipRequests || visibility_level > 1;
} }
}); });

2
app/assets/javascripts/discourse/models/group.js.es6
View File

@ -139,7 +139,7 @@ const Group = RestModel.extend({
@computed("visibility_level") @computed("visibility_level")
isPrivate(visibilityLevel) { isPrivate(visibilityLevel) {
return ![0, 1].includes(visibilityLevel); return visibility_level > 1;
}, },
@observes("isPrivate", "canEveryoneMention") @observes("isPrivate", "canEveryoneMention")