DEV: Change hide_email_address_taken default to true (#30293)

We're changing the default of hide_email_address_taken to true. This is a trade-off we want to make, as it prevents account enumeration with minimal impact on legitimate users. If you forget you have an account and try to sign up again with the same e-mail you'll receive an e-mail letting you know.

app/assets/javascripts/discourse/tests/acceptance/forgot-password-test.js

@@ -7,6 +7,10 @@ let userFound = false;
 
 acceptance("Forgot password", function (needs) {
   needs.pretender((server, helper) => {
+    needs.settings({
+      hide_email_address_taken: false,
+    });
+
     server.post("/session/forgot_password", () => {
       return helper.response({
         user_found: userFound,
@@ -78,6 +82,10 @@ acceptance("Forgot password", function (needs) {
 acceptance(
   "Forgot password - hide_email_address_taken enabled",
   function (needs) {
+    needs.settings({
+      hide_email_address_taken: true,
+    });
+
     needs.pretender((server, helper) => {
       server.post("/session/forgot_password", () => {
         return helper.response({});
@@ -93,12 +101,12 @@ acceptance(
         .dom(".forgot-password-reset")
         .isDisabled("disables the button until the field is filled");
 
-      await fillIn("#username-or-email", "someuser");
+      await fillIn("#username-or-email", "someuser@discourse.org");
       await click(".forgot-password-reset");
 
       assert.dom(".d-modal__body").hasHtml(
-        i18n("forgot_password.complete_username", {
-          username: "someuser",
+        i18n("forgot_password.complete_email", {
+          email: "someuser@discourse.org",
         }),
         "displays a success message"
       );

config/site_settings.yml

@@ -621,7 +621,7 @@ login:
     list_type: simple
   hide_email_address_taken:
     client: true
-    default: false
+    default: true
   log_out_strict: false
   pending_users_reminder_delay_minutes:
     min: -1

plugins/automation/spec/integration/core_ext_spec.rb

@@ -119,6 +119,8 @@ describe "Core extensions" do
 
   describe "user custom fields" do
     it "supports discourse_automation_ids" do
+      SiteSetting.hide_email_address_taken = false
+
       user = create_user
       automation_1.add_id_to_custom_field(user, DiscourseAutomation::AUTOMATION_IDS_CUSTOM_FIELD)
 

spec/integration/invite_only_registration_spec.rb

@@ -5,6 +5,7 @@ RSpec.describe "invite only" do
   describe "#create invite only" do
     it "can create user via API" do
       SiteSetting.invite_only = true
+      SiteSetting.hide_email_address_taken = false
       Jobs.run_immediately!
 
       admin = Fabricate(:admin)

spec/lib/email_updater_spec.rb

@@ -5,6 +5,8 @@ RSpec.describe EmailUpdater do
   let(:new_email) { "new.email@example.com" }
 
   it "provides better error message when a staged user has the same email" do
+    SiteSetting.hide_email_address_taken = false
+
     Fabricate(:user, staged: true, email: new_email)
 
     user = Fabricate(:user, email: old_email)

spec/models/invite_spec.rb

@@ -117,6 +117,8 @@ RSpec.describe Invite do
     end
 
     it "escapes the email_address when raising an existing user error" do
+      SiteSetting.hide_email_address_taken = false
+
       user.email = xss_email
       user.save(validate: false)
 

spec/requests/api/users_spec.rb

@@ -656,6 +656,8 @@ RSpec.describe "users" do
   end
 
   path "/session/forgot_password.json" do
+    SiteSetting.hide_email_address_taken = false
+
     post "Send password reset email" do
       tags "Users"
       operationId "sendPasswordResetEmail"

spec/requests/users_controller_spec.rb

@@ -1013,6 +1013,8 @@ RSpec.describe UsersController do
     end
 
     context "when creating as active" do
+      before { SiteSetting.hide_email_address_taken = false }
+
       it "won't create the user as active" do
         post "/u.json", params: post_user_params.merge(active: true)
         expect(response.status).to eq(200)
@@ -2042,6 +2044,8 @@ RSpec.describe UsersController do
   end
 
   describe "#check_email" do
+    before { SiteSetting.hide_email_address_taken = false }
+
     it "returns success if hide_email_address_taken is true" do
       SiteSetting.hide_email_address_taken = true
 

spec/requests/users_email_controller_spec.rb

@@ -207,12 +207,26 @@ RSpec.describe UsersEmailController do
       context "when new email is different case of existing email" do
         fab!(:other_user) { Fabricate(:user, email: "case.insensitive@gmail.com") }
 
-        it "raises an error" do
-          put "/u/#{user.username}/preferences/email.json",
-              params: {
-                email: other_user.email.upcase,
-              }
-          expect(response).to_not be_successful
+        context "when hiding taken e-mails" do
+          it "raises an error" do
+            put "/u/#{user.username}/preferences/email.json",
+                params: {
+                  email: other_user.email.upcase,
+                }
+            expect(response).to be_successful
+          end
+        end
+
+        context "when revealing taken e-mails" do
+          before { SiteSetting.hide_email_address_taken = false }
+
+          it "raises an error" do
+            put "/u/#{user.username}/preferences/email.json",
+                params: {
+                  email: other_user.email.upcase,
+                }
+            expect(response).to_not be_successful
+          end
         end
       end
 

spec/system/email_change_spec.rb

@@ -51,6 +51,8 @@ describe "Changing email", type: :system do
   end
 
   it "works when user has totp 2fa" do
+    SiteSetting.hide_email_address_taken = false
+
     second_factor = Fabricate(:user_second_factor_totp, user: user)
     sign_in user
 

spec/system/login_spec.rb

@@ -10,7 +10,10 @@ shared_examples "login scenarios" do |login_page_object|
   fab!(:admin) { Fabricate(:admin, username: "admin", password: "supersecurepassword") }
   let(:user_menu) { PageObjects::Components::UserMenu.new }
 
-  before { Jobs.run_immediately! }
+  before do
+    SiteSetting.hide_email_address_taken = false
+    Jobs.run_immediately!
+  end
 
   def wait_for_email_link(user, type)
     wait_for(timeout: 5) { ActionMailer::Base.deliveries.count != 0 }

spec/system/signup_spec.rb

@@ -221,7 +221,10 @@ shared_examples "signup scenarios" do |signup_page_object, login_page_object|
   end
 
   context "when the email domain is blocked" do
-    before { SiteSetting.blocked_email_domains = "example.com" }
+    before do
+      SiteSetting.hide_email_address_taken = false
+      SiteSetting.blocked_email_domains = "example.com"
+    end
 
     it "cannot signup" do
       signup_form