github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-01-18 13:32:45 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

PERF: skip reset flag callbacks on seed (#28333)

Browse Source 
When flags are seeded, we don't need to reset the cache for each record.

We should instead create all flags and reset the cache at the very end.
This commit is contained in:
Krzysztof Kotlarek 2024-08-13 13:22:57 +10:00 committed by GitHub
parent 09262ac9b9
commit c1f6ec3019
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/models/flag.rb
View File

@ -14,7 +14,9 @@ class Flag < ActiveRecord::Base
before_save :set_position
before_save :set_name_key
after_commit :reset_flag_settings!
after_commit { reset_flag_settings! if !skip_reset_flag_callback }
attr_accessor :skip_reset_flag_callback
default_scope do
order(:position).where(score_type: false).where.not(id: PostActionType::LIKE_POST_ACTION_ID)

10
db/fixtures/003_flags.rb
View File

@ -1,5 +1,4 @@
# frozen_string_literal: true
Flag.seed do |s|
s.id = 6
s.name = "notify_user"
@ -7,6 +6,7 @@ Flag.seed do |s|
s.auto_action_type = false
s.require_message = true
s.applies_to = %w[Post Chat::Message]
s.skip_reset_flag_callback = true
end
Flag.seed do |s|
s.id = 3
@ -15,6 +15,7 @@ Flag.seed do |s|
s.auto_action_type = true
s.require_message = false
s.applies_to = %w[Post Chat::Message]
s.skip_reset_flag_callback = true
end
Flag.seed do |s|
s.id = 4
@ -23,6 +24,7 @@ Flag.seed do |s|
s.auto_action_type = true
s.require_message = false
s.applies_to = %w[Post Topic Chat::Message]
s.skip_reset_flag_callback = true
end
Flag.seed do |s|
s.id = 8
@ -31,6 +33,7 @@ Flag.seed do |s|
s.auto_action_type = true
s.require_message = false
s.applies_to = %w[Post Topic Chat::Message]
s.skip_reset_flag_callback = true
end
Flag.seed do |s|
s.id = 10
@ -39,6 +42,7 @@ Flag.seed do |s|
s.auto_action_type = false
s.require_message = true
s.applies_to = %w[Post Topic Chat::Message]
s.skip_reset_flag_callback = true
end
Flag.seed do |s|
s.id = 7
@ -47,6 +51,7 @@ Flag.seed do |s|
s.auto_action_type = false
s.require_message = true
s.applies_to = %w[Post Topic Chat::Message]
s.skip_reset_flag_callback = true
end
Flag.unscoped.seed do |s|
s.id = 9
@ -56,6 +61,7 @@ Flag.unscoped.seed do |s|
s.require_message = false
s.score_type = true
s.applies_to = %w[]
s.skip_reset_flag_callback = true
end
Flag.unscoped.seed do |s|
s.id = 2
@ -65,4 +71,6 @@ Flag.unscoped.seed do |s|
s.require_message = false
s.score_type = false
s.applies_to = %w[Post]
s.skip_reset_flag_callback = true
end
Flag.reset_flag_settings!