github-mirror/discourse
2
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-24 04:31:56 +08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

FIX: Autoplay videos must always be muted (#11533)

Browse Source 
This automatically adds the muted attribute if it's missing in a video
tag.

Co-authored-by: David Taylor <david@taylorhq.com>
This commit is contained in:
Rafael dos Santos Silva 2020-12-21 14:55:00 -03:00 committed by GitHub
parent 38950840e0
commit c4552e9c10
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 39 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
app/assets/javascripts/discourse/tests/unit/lib/sanitizer-test.js
View File

@ -168,6 +168,38 @@ module("Unit | Utility | sanitizer", function () {
);
});
test("autoplay videos must be muted", function (assert) {
let pt = new PrettyText(buildOptions({ siteSettings: {} }));
assert.ok(
pt
.sanitize(
`<p>Hey</p><video autoplay src="http://example.com/music.mp4"/>`
)
.match(/muted/)
);
assert.ok(
pt
.sanitize(
`<p>Hey</p><video autoplay><source src="http://example.com/music.mp4" type="audio/mpeg"></video>`
)
.match(/muted/)
);
assert.ok(
pt
.sanitize(
`<p>Hey</p><video autoplay muted><source src="http://example.com/music.mp4" type="audio/mpeg"></video>`
)
.match(/muted/)
);
assert.notOk(
pt
.sanitize(
`<p>Hey</p><video><source src="http://example.com/music.mp4" type="audio/mpeg"></video>`
)
.match(/muted/)
);
});
test("poorly formed ids on headings", function (assert) {
let pt = new PrettyText(buildOptions({ siteSettings: {} }));
assert.equal(

2
app/assets/javascripts/pretty-text/addon/allow-lister.js
View File

@ -225,7 +225,7 @@ export const DEFAULT_LIST = [
"track[srclang]",
"ul",
"video",
"video[autoplay]",
// video[autoplay] handled by sanitizer.js
"video[controls]",
"video[controlslist]",
"video[crossorigin]",

6
app/assets/javascripts/pretty-text/addon/sanitizer.js
View File

@ -126,6 +126,12 @@ export function sanitize(text, allowLister) {
return "-STRIP-";
}
if (tag === "video" && name === "autoplay") {
// This might give us duplicate 'muted' atttributes
// but they will be deduped by later processing
return "autoplay muted";
}
// Heading ids must begin with `heading--`
if (
["h1", "h2", "h3", "h4", "h5", "h6"].indexOf(tag) !== -1 &&