PERF: batch expensive post-migration (#11845)

Run the 'MigrateSearchDataAfterDefaultLocaleRename' post migration in batches of 500k records.

This will hopefully prevent any potential deadlocks on large tables.
This commit is contained in:
Régis Hanol 2021-01-25 22:58:58 +01:00 committed by GitHub
parent 568bad75c1
commit c56ba6c9bd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1,12 +1,10 @@
# frozen_string_literal: true
class MigrateSearchDataAfterDefaultLocaleRename < ActiveRecord::Migration[6.0]
disable_ddl_transaction!
def up
move_search_data("category_search_data")
move_search_data("post_search_data")
move_search_data("tag_search_data")
move_search_data("topic_search_data")
move_search_data("user_search_data")
%w{category tag topic post user}.each { |model| fix_search_data(model) }
end
def down
@ -15,14 +13,25 @@ class MigrateSearchDataAfterDefaultLocaleRename < ActiveRecord::Migration[6.0]
private
def move_search_data(table_name)
execute <<~SQL
UPDATE #{table_name} x
def fix_search_data(model)
key = "#{model}_id"
table = "#{model}_search_data"
sql = <<~SQL
UPDATE #{table}
SET locale = 'en'
WHERE #{key} IN (
SELECT #{key}
FROM #{table}
WHERE locale = 'en_US'
LIMIT 500000
)
SQL
rescue
# Probably a unique key constraint violation. A background job might have inserted conflicting data during the UPDATE.
# We can safely ignore this error. The ReindexSearch job will eventually fix the data.
loop do
count = execute(sql).cmd_tuples
break if count == 0
puts "Migrated #{count} rows of #{table} to new locale."
end
end
end